Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Form conversion: Compute/Infra/PXE ISO Datastores - Add ISO Datastores #7660

Closed
h-kataria opened this issue Mar 12, 2021 · 2 comments
Closed

Comments

@h-kataria
Copy link
Contributor

h-kataria commented Mar 12, 2021

Convert form to use DDF/React and API - parent issue #6825

Location: Compute/Infra/PXE ISO Datastores
Screen Shot 2021-03-12 at 12 57 48 PM

Form: Add ISO Datastore
API: ManageIQ/manageiq-api#992

@h-kataria h-kataria changed the title Form conversion: Compute/Infra/PXE ISO Datastores - Add/Edit ISO Datastores Form conversion: Compute/Infra/PXE ISO Datastores - Add ISO Datastores Mar 12, 2021
@DavidResende0
Copy link
Member

DavidResende0 commented Mar 15, 2021

image

There's no API endpoint for this select field right now and the data currently comes from here:

manageiq-ui-classic/app/controllers/pxe_controller/iso_datastores.rb

@edit[:emses] = ManageIQ::Providers::Redhat::InfraManager
                    .without_iso_datastores
                    .order(:name)
                    .pluck(:name, :id)

I've made an issue in the API repo to address it (ManageIQ/manageiq-api#1020) but alternatively I could add some code to the select that would compare all the current ISO datastores (/api/iso_datastores) with all the Infrastructure Management providers (/api/providers?collection_class=ManageIQ::Providers::Redhat::InfraManager) to filter out the "unused" providers.

Thoughts? @gtanzillo @Fryguy

@DavidResende0
Copy link
Member

@kavyanekkalapu or @Fryguy this issue can be closed since the form is merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants