Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the material attribute in HitRecord a reference instead of a Trait object #3

Open
Mandragorian opened this issue May 18, 2018 · 0 comments

Comments

@Mandragorian
Copy link
Owner

The material attribute in the HitRecord struct is a Trait object. This is not needed, since the HitRecord shouldn't own a copy of the material, and it is also innefficient, since a copy of the material struct takes place.

Instead, the material attribute should be defined as a reference to something that implements the Material trait.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant