Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor README and Vignette(s) #227

Open
1 of 2 tasks
MattCowgill opened this issue Feb 15, 2023 · 4 comments
Open
1 of 2 tasks

Refactor README and Vignette(s) #227

MattCowgill opened this issue Feb 15, 2023 · 4 comments
Assignees

Comments

@MattCowgill
Copy link
Owner

MattCowgill commented Feb 15, 2023

We now have three broad groups of functions:

  • Functions (such as read_abs()) to load ABS time series data
  • Functions (such as download_abs_data_cube() to load ABS data cubes
  • Functions (such as read_api()) to load data from the ABS.Stat API

The README should make it clear what each of these groups of functions are, what they do, and when you would use one over the other. Each group of functions should have a separate vignette OR a clearly-delineated separate section in a single vignette.

  • README
  • Vignette(s)
@MattCowgill MattCowgill self-assigned this Feb 15, 2023
MattCowgill added a commit that referenced this issue Feb 16, 2023
MattCowgill added a commit that referenced this issue Feb 16, 2023
* rebuild docs index

* iterate version, update NEWS

* rewrite README, see #227

* local refresh of sysdata
@palesl
Copy link

palesl commented Feb 17, 2023

functions work but help files are (apparently) corrupted (see below), not sure if me or the documentation. probably me honestly.

`Downloading GitHub repo mattcowgill/readabs@HEAD
── R CMD build ──────────────────────────────────────────────────
✔ checking for file ‘/private/var/folders/fg/5j7kqkrs16n_y_bq3rhkzlqnswp4y_/T/Rtmpp5NBaO/remotes68e43c892ebc/MattCowgill-readabs-82387c2/DESCRIPTION’ ...
─ preparing ‘readabs’:
✔ checking DESCRIPTION meta-information ...
─ checking for LF line-endings in source and make files and shell scripts
─ checking for empty or unneeded directories
─ looking to see if a ‘data/datalist’ file should be added
─ building ‘readabs_0.4.13.901.tar.gz’
Warning: invalid uid value replaced by that for user 'nobody'
Warning: invalid gid value replaced by that for user 'nobody'

Installing package into ‘/Users/u1040068/Library/R/arm64/4.2/library’
(as ‘lib’ is unspecified)

  • installing source package ‘readabs’ ...
    ** using staged installation
    ** R
    ** byte-compile and prepare package for lazy loading
    ** help
    *** installing help indices
    *** copying figures
    ** building package indices
    ** installing vignettes
    ** testing if installed package can be loaded from temporary location
    ** testing if installed package can be loaded from final location
    ** testing if installed package keeps a record of temporary installation path
  • DONE (readabs)

library(readabs)
Environment variable 'R_READABS_PATH' is unset. Downloaded files will be saved in a temporary directory.
You can set 'R_READABS_PATH' at any time. To set it for the rest of this session, use
Sys.setenv(R_READABS_PATH = )
Error in fetch(key) :
lazy-load database '/Users/u1040068/Library/R/arm64/4.2/library/readabs/help/readabs.rdb' is corrupt`

@MattCowgill
Copy link
Owner Author

Very weird @palesl, I’ll check it out

@MattCowgill
Copy link
Owner Author

Hi @palesl, I can't reproduce this, which is weird! We're both on arm64 (Apple Silicon) machines, too.

Could you please try restarting R, then doing this again?

remotes::install_github("MattCowgill/readabs") 
library(readabs)

@palesl
Copy link

palesl commented Feb 19, 2023

HI Matt, yes it seems to work now, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants