Aesthetics and details

[eroten]

• ditch absolutePanel()s; they cause accessibility issues
• set max width for entire app; current width is WAY too wide
• use consistent basemap for all leaflet plots
• use consistent margin and border values for all objects
• detailed review of inst/app/style.css
• check text hierarchy sizes
• do cursory mobile-ready evaluation
• plotly styling
  • axis typeface and title
  • hover box text, typeface, text color, background color, opacity
• review user instructions and narrative text (will involve Darcie and Krysten)
• consider using a loading spinner on maps and plots
• update package references
• review Intro and note tabs css

[eroten]

@ehesch do you want me to take a stab at loading spinners? I've had success in the past using {waiter}. There is a spiffy demo page here

[ehesch]

@eroten , sorry! didn't see this until now. I can probably add a spinner - I've made some changes as you probably noticed. Most saliently I moved away from plotly in favor of ggplot (in order to have the plots include the "agency average" and also look decent regardless of how many points are selected - apparently a concern is that folks might grab the figures directly from the app, and thus I thought it prudent to have the best figs possible, even if the interactivity is a bit less elegant. I'll do a push tomorrow morn and we can chat about what's up?

[eroten]

@ehesch no worries! I made a few aesthetic changes (font and icon sizes, park status colors, padding), adjusted the HTML paragraph text, restricted the zoom level on the transit stops layer in leaflet, and tried to fix the issue with #22 (no luck). Everything is pushed to the 19-aesthetics-and-details branch. 😃

[eroten]

I think that would be fine! The legend and popup will update, so that will help reduce confusion. The changing color palettes worked well when we wanted to clearly differentiate each set (Race, Ethnicity, Age), but since we are balancing more colors, it should be fine to just choose the best palette that works with the park status colors

[ehesch]

@eroten waiter added to maps, not sure I love its current iteration but definitely like the idea!

[ehesch]

@eroten YAY - deployed, working, etc.! Much speedier too. Not 100% sure what was causing some of the funky issues. Rebuilding did give an opportunity to clean up each module, the entire package, etc. which is a nice consolation prize I guess?! 🤷

CHECK IT OUT!

Re-creating/updating your checklist....

• re-consider adding a waiter
• *&!$ leaflet doesn't render polygons until the maps are interacted with! The fix from before does not get along with the deployment ....
• consider styling on sidepanels for Map pane, especially (it's quite long currently)
• consider adding button for leaflet.extras::fullscreen (was slowing things down when I was doing this, so it didn't seem worth it?)
• consider adding mapshot and/or broadband style downloadable map to a tab where individual units can be isolated with the map polygons
• consider putting legend back in ggplot summary maps so it downloads with plot
• i kind of hate the leaflet percentile legends....would be nice to show the real numbers
• might be nice if leaflet legends could be drug around by users

Longer term...

• text input from colleagues
• user experience input from colleagues
• detailed user guide
• can we automate updates (ie pop forecasts are re-done quarterly, acs updated annually) OR include some kind of obvious way users can note the "vintage" of the data pieces

[ehesch]

urg, download button on the summary --> table isn't working :/ not sure what's going on there.....

[eroten]

@ehesch Hooray! The app is so much faster now, and has cleaned up nicely!

I took some of the checklist items in your last comment and broke them into two new issues (#23 and #24). Its generally better to have several smaller issues rather than one massive one, particularly since we are venturing outside appearance changes with this issue. I've crossed out the items that I moved to other issues.

• re-consider adding a waiter
• *&!$ leaflet doesn't render polygons until the maps are interacted with! The fix from before does not get along with the deployment ....
• consider styling on sidepanels for Map pane, especially (it's quite long currently)
• consider adding button for leaflet.extras::fullscreen (was slowing things down when I was doing this, so it didn't seem worth it?)
• consider adding mapshot and/or broadband style downloadable map to a tab where individual units can be isolated with the map polygons
• consider putting legend back in ggplot summary maps so it downloads with plot
• i kind of hate the leaflet percentile legends....would be nice to show the real numbers
• might be nice if leaflet legends could be drug around by users

Longer term...

• text input from colleagues
• user experience input from colleagues
• detailed user guide
• can we automate updates (ie pop forecasts are re-done quarterly, acs updated annually) OR include some kind of obvious way users can note the "vintage" of the data pieces

The only three items left are

• re-consider adding a waiter
• consider styling on sidepanels for Map pane, especially (it's quite long currently)
• consider putting legend back in ggplot summary maps so it downloads with plot

[ehesch]

have reconsidered the waiter; I think it's no longer necessary becuase the app has been lightened significantly (only 1 map!) and no longer takes forever and a year to load :)