Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No alpha support #1

Open
execomrt opened this issue Mar 3, 2018 · 5 comments
Open

No alpha support #1

execomrt opened this issue Mar 3, 2018 · 5 comments

Comments

@execomrt
Copy link

execomrt commented Mar 3, 2018

xBRZ should support alpha channel. Currently it is stripped. Is it possible to add it ?

@MiYanni
Copy link
Owner

MiYanni commented Mar 3, 2018

@execomrt I don't see why not. Can you provide an example image I could use for testing, like those found here?

@execomrt
Copy link
Author

execomrt commented Dec 18, 2018

From the xBRZScaler.cs, it says : alpha channel is unused

-> map source (srcWidth * srcHeight) to target (scale * width x scale * height)
image, optionally processing a half-open slice of rows [yFirst, yLast) only
-> color format: ARGB (BGRA char order), alpha channel unused

@MiYanni
Copy link
Owner

MiYanni commented Dec 18, 2018

@execomrt Correct. I'd have to implement the alpha channel support into the algorithm. Can you provide an image to test with? (Meaning, one that contains an alpha channel that you wish to scale)

@execomrt
Copy link
Author

execomrt commented Dec 18, 2018

flamealpha

or https://sourceforge.net/projects/xbrz/files/latest/download (there are a lot of images).

I've tried to changed on my side, but since you used signed int for bitmap element, there were a lot of refactor. Check the .CPP code, there is a special case for handling distance of alpha value (source code is on Sourceforge.net, updated in Mars 2018)(

@MiYanni
Copy link
Owner

MiYanni commented Dec 19, 2018

@execomrt If you want to create a pull request, I can at least take a look at the changes you were doing. Maybe tweak them and see if I can reduce the refactoring required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants