Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Constants FIle #8

Open
DJDMVP opened this issue Sep 10, 2024 · 2 comments
Open

Constants FIle #8

DJDMVP opened this issue Sep 10, 2024 · 2 comments
Assignees
Labels
flight Flight subteam / controls the flight or overarching control of the drone good first issue Good for newcomers

Comments

@DJDMVP
Copy link

DJDMVP commented Sep 10, 2024

Constants File

Problem

There are multiple values that are used throughout many of the files that could be kept better by putting it in a single constants file. This could include max speed, takeoff altitude, and other values similar to that.

Solution

Create a python file to store all of the constants file for them to be used throughout the codebase.

Additional Information

Make sure the values added aren't values that are changed while the code is running, and make sure the values don't overlap with the config file.

@DJDMVP DJDMVP added good first issue Good for newcomers flight Flight subteam / controls the flight or overarching control of the drone labels Sep 10, 2024
@J-The-Fox
Copy link
Member

Would this be in the same file structure as vision with a common folder or would this just be a constants.py file directly?

@DJDMVP
Copy link
Author

DJDMVP commented Sep 27, 2024

Just directly in the flight folder

@J-The-Fox J-The-Fox self-assigned this Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flight Flight subteam / controls the flight or overarching control of the drone good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants