Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Layouts are broken and inconsistent #16

Open
MoralCode opened this issue Oct 8, 2019 · 2 comments
Open

Layouts are broken and inconsistent #16

MoralCode opened this issue Oct 8, 2019 · 2 comments
Labels
good first issue Smaller issues that are great first issues for anyone interested in helping out help wanted Extra attention is needed
Milestone

Comments

@MoralCode
Copy link
Owner

MoralCode commented Oct 8, 2019

  • layouts on schedule page and select school page are taking up the enitre page width
  • settings page layout is surrounded in a div with auto margins so it looks fine
    • except the longest line of text sets the width (because auto widths) and if that text is dynamic (i.e. has bold on hover) the whole layout moves on hover
  • the main page has no encapsulating div and everything is just auto-margin centered

ideally there would be a <Page> component or something to wrap each page's content to make layouts consistent (and provide a slightly cleaner way to handle the corner navigation buttons and other inter-page stuff)

@MoralCode
Copy link
Owner Author

MoralCode commented Feb 9, 2020

appears to have been fixed in b7feed1. the site just has not been built since then :/

@MoralCode
Copy link
Owner Author

deployed in aa44f44.

Screenshot_20200217_084405
🙄

@MoralCode MoralCode added this to the MVP milestone Jan 6, 2021
@MoralCode MoralCode added help wanted Extra attention is needed good first issue Smaller issues that are great first issues for anyone interested in helping out labels Oct 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Smaller issues that are great first issues for anyone interested in helping out help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant