Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Model dimensions should be determined automatically #7

Open
MosGeo opened this issue Jun 11, 2018 · 1 comment
Open

Model dimensions should be determined automatically #7

MosGeo opened this issue Jun 11, 2018 · 1 comment
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@MosGeo
Copy link
Owner

MosGeo commented Jun 11, 2018

Right now, nDim is needed for to determine where the model is located in the project directory. How about having the code search in all directories and just finds the right model automatically.

@MosGeo MosGeo added enhancement New feature or request good first issue Good for newcomers labels Jun 11, 2018
@MosGeo MosGeo self-assigned this Jun 11, 2018
@tanvidc
Copy link
Collaborator

tanvidc commented Oct 23, 2018

Easy to solve but what if someone has same model name eg. salinas_a in 1D as well as 2D? Ask them to specify nDim only in that case?

Dimension is easy to specify once in main, and folks usually will deal with any one dimension at a time, so maybe its ok the way it is perhaps. Like the labels!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants