Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The conceptual design of the Rhea beacon may need some refinement based on its nature #7

Open
RichardBruskiewich opened this issue Aug 21, 2018 · 3 comments

Comments

@RichardBruskiewich
Copy link
Collaborator

Rhea is an unusual resource in that each entry is, in fact, seems to be a reaction. The underlying concepts behind each reaction are chemical compounds, primarily indexed in CHEBI. It could perhaps be argued that the CHEBI entries are the real beacon concepts lurking in this knowledge source, and that the Rhea entries themselves are the "statements". In fact, one wonders if one could somehow return meaningful subgraphs (rather than single statements) that are tagged by Rhea 'statement' identifiers(?). In this spirit, classical beacon 'statements' would only be a degenerate, trivial form of statement (two concepts plus a single edge)?

Does this do violence to the concept of a beacon?

@cmungall
Copy link
Member

cmungall commented Nov 9, 2018

I think shortcut edges are fine, but I think the reactions should be nodes too

E.g.

   R
 /   \
C-----C

Also it looks like you are modeling ECs as gene products, GO treats EC, RHEA and GO-MF as biolink molecular activities, in equivalence cliques

@RichardBruskiewich
Copy link
Collaborator Author

Roger that @cmungall.

I think the Biolink model (of concepts) accepts multiple categories now, right. So tagging EC's both as gene products (perhaps even gene?) as well as molecular activities, would likely be both feasible and advantageous?

I think after this particular issue was posted, we concluded that yes, include R's in the concept lists exported. Just need to properly tag them(?). Do they have type aligned with EC's, but only "molecular activity"?

@cmungall
Copy link
Member

cmungall commented Nov 9, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants