Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gene to Pathway - Some ARS Agents Currently Returning 0 Results #9

Open
sstemann opened this issue Mar 10, 2021 · 13 comments
Open

Gene to Pathway - Some ARS Agents Currently Returning 0 Results #9

sstemann opened this issue Mar 10, 2021 · 13 comments

Comments

@sstemann
Copy link
Contributor

sstemann commented Mar 10, 2021

https://github.com/NCATSTranslator/testing/blob/main/ars-requests/not-none/pathway.json

  • the query has been updated since this morning to correctly capitalize NCBIGENE:1017
  • the parent PK is 5e3f38b6-2b23-479c-b04e-81fce973ca52
  • as of weds 3/10 : 4525e749-aef6-4025-9c54-b90cfd064305
  • as of fri 3/19: 56085e63-c878-4634-8a70-69810f858e1e

Based on the updated query: ARAX, ARAGORN, and BTE are now returning various results.

Adding the non-responsive ARA reps to the assignees, but the KPs are the domain specialists and should serve as a resource to explore what could be done to answer/expand on queries like the one proposed.

@NCATSTranslator/translator-standup for KPs to take a look at and determine if they can fill gaps on the query for ARAs, assigning to non-responsive ARA reps to the assignees to provide feedback here or open tickets in their repos and add the link here, but the KPs are the domain specialists and should serve as a resource to explore what could be done to answer/expand on queries like the one proposed.

@sstemann sstemann changed the title Some ARAs Currently Returning 0 Results for Gene to Pathway Some ARS Agents Currently Returning 0 Results for Gene to Pathway Mar 12, 2021
@sstemann
Copy link
Contributor Author

Explanatory Agent - no support for this particular predicate (gene-pathway association) but are hitting MolePro
Improving Agent - capitalization we confirmed change, need to implement gene-pathway, not finding the CURIE also

Unsecret - hits Molepro, Vlado exposed pathways (but 0.9.2 compliant) - so both have results but marked as non-compliant

@sstemann
Copy link
Contributor Author

@cbizon are the ARAGORN message IDs:

Weds @ 9am: 9aa08c33-0cd0-4401-b834-f2b59b585f14
Fri @ 950am: 3e32f299-c335-4b79-9b3e-443661bc626f

@cbizon
Copy link
Collaborator

cbizon commented Mar 12, 2021

@cbizon are the ARAGORN message IDs:

Weds @ 9am: 9aa08c33-0cd0-4401-b834-f2b59b585f14
Fri @ 950am: 3e32f299-c335-4b79-9b3e-443661bc626f

We recently updated the URL that the ARS should be hitting. For some reason (maybe the change just hadn't gone through yet) the Wed version was hitting the old URL, which gave results, but these results were buggy.

The "correct" result is that there were no results coming back.

We're working on pulling this information from various KPs, documented in our ticket ranking-agent/strider#107 and KP tickets linked from there.

@ehinderer
Copy link

I suspect that Explanatory Agent is not returning results because we do not yet have a use-case that includes gene-pathway associations and as such, do not have a workflow in place to return a response including that predicate. We have use cases for other predicates in MolePro. The new requirements for full integration dictates that we account for all predicates in supported KPs, so we will be looking into this.
@pg427
@tziomics

@sstemann
Copy link
Contributor Author

I suspect that Explanatory Agent is not returning results because we do not yet have a use-case that includes gene-pathway associations and as such, do not have a workflow in place to return a response including that predicate. We have use cases for other predicates in MolePro. The new requirements for full integration dictates that we account for all predicates in supported KPs, so we will be looking into this.
@pg427
@tziomics

@ehinderer do you all track this in github or somewhere we can link to?

@cbizon
Copy link
Collaborator

cbizon commented Mar 17, 2021

With the BTE fix, we're now returning results for this query.

@ehinderer
Copy link

@sstemann I've commented to check additional 0-results errors in issue 18 NCATSTranslator/Explanatory-Agent#18.

@sstemann sstemann changed the title Some ARS Agents Currently Returning 0 Results for Gene to Pathway Gene to Pathway - Some ARS Agents Currently Returning 0 Results Mar 22, 2021
@sstemann
Copy link
Contributor Author

sstemann commented Apr 20, 2021

as of 4/20/21 (PK: 605fc2ef-58bd-4176-8661-9a5a09f26c83):
image

@balhoff
Copy link

balhoff commented Jun 29, 2021

CAM-KP has data for this gene, but not related to any concepts mapped to biolink:Pathway (i.e., GO:0007165). Generalizing to biolink:BiologicalProcess returns GO:0030851 'granulocyte differentiation'.

@sstemann
Copy link
Contributor Author

@cbizon previously ARAGORN responded to this query. The query has been updated for v1.1 The results are here: 3eb5b2de-c28f-4cec-a1df-3584fbc25d3d

ARAGORN now has 0.

image

@sstemann
Copy link
Contributor Author

sstemann commented Jul 19, 2021

@cbizon sorry for my confusion - i think during the evolution of this query - we changed it from Pathway to BiologicalProcess. So using BiologicalProcess instead of Pathway - ARAGORN does respond. 87aff34f-c138-4618-92f7-f8b1e8287f1d

However, now Textmining responds to pathway but not biologicalprocess @bill-baumgartner so i'm not sure which

@sstemann
Copy link
Contributor Author

TRAPI v1.1 Queries as of 7/20:

  1. Biological Process
  2. Pathway

@colleenXu
Copy link
Contributor

I ran the updated query below through the ARS, PK: f4818fbf-9293-4f33-bc3e-b184ea8dc193

Screen Shot 2021-09-21 at 11 21 05 PM

The updated query should be something like this (it's missing the workflow section but the rest is TRAPI v1.2):

{
    "message": {
        "query_graph": {
            "nodes": {
                "n0": {
                    "ids": ["NCBIGene:1017"],
		            "categories":["biolink:Gene"]
                },
                "n1": {
                    "categories": ["biolink:Pathway"]
                }
            },
            "edges": {
                "e0": {
                    "subject": "n0",
                    "object": "n1"
                }
            }
        }
    }
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

9 participants