Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove near-api-js' Account object dependency from set function #37

Closed
kieranroneill opened this issue Jul 23, 2024 · 0 comments · Fixed by #38
Closed

Remove near-api-js' Account object dependency from set function #37

kieranroneill opened this issue Jul 23, 2024 · 0 comments · Fixed by #38
Assignees
@kieranroneill
Labels
✨ feature New feature or request ♻️ refactor The refactoring fairy has waved their magic wand

Comments

@kieranroneill
Copy link
Collaborator

kieranroneill commented Jul 23, 2024 •
edited by jaswinder6991
Loading

Summary

Currently, change functions require a dependency on the near-api-js' Account object. However, this is almost impossible to use in some contexts (like the wallet selector).

As the set function doesn't really need the whole Account object, we can just use the account ID and take the RPC URL to use as the connection.
@kieranroneill kieranroneill self-assigned this Jul 23, 2024
@kieranroneill kieranroneill converted this from a draft issue Jul 23, 2024
@kieranroneill kieranroneill added ✨ feature New feature or request ♻️ refactor The refactoring fairy has waved their magic wand labels Jul 23, 2024
@kieranroneill kieranroneill changed the title Remove near-api-js' Accountobject dependency from set function Remove near-api-js' Account object dependency from set function Jul 23, 2024
@kieranroneill kieranroneill linked a pull request Jul 25, 2024 that will close this issue
feat: remove near-api-js account object dependency from change functions #38
Merged
11 tasks
@github-project-automation github-project-automation bot moved this from In Progress to Done in near-social-js Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kieranroneill kieranroneill

Labels
✨ feature New feature or request ♻️ refactor The refactoring fairy has waved their magic wand
Projects
near-social-js
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: remove near-api-js account object dependency from change functions NEARBuilders/near-social-js
1 participant
@kieranroneill