From 983bb9ec5fb058e54866d45887528fe51ed71605 Mon Sep 17 00:00:00 2001 From: "Anders L. Kolstad" <33656949+anders-kolstad@users.noreply.github.com> Date: Tue, 3 Dec 2024 10:23:19 +0100 Subject: [PATCH] Update and rename PR-checklist.md to PR-review-checklist.md --- .../{PR-checklist.md => PR-review-checklist.md} | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) rename .github/ISSUE_TEMPLATE/{PR-checklist.md => PR-review-checklist.md} (95%) diff --git a/.github/ISSUE_TEMPLATE/PR-checklist.md b/.github/ISSUE_TEMPLATE/PR-review-checklist.md similarity index 95% rename from .github/ISSUE_TEMPLATE/PR-checklist.md rename to .github/ISSUE_TEMPLATE/PR-review-checklist.md index ece5641..62bfc1a 100644 --- a/.github/ISSUE_TEMPLATE/PR-checklist.md +++ b/.github/ISSUE_TEMPLATE/PR-review-checklist.md @@ -1,5 +1,5 @@ --- -name: PR checklist +name: PR review checklist about: A checklist for processing new PRs with indicator documentation title: '[New PR]: "indicatorID"' labels: PR-checklist @@ -7,7 +7,7 @@ assignees: anders-kolstad --- -## PR checklist +## PR review checklist This is a checklist for ecRxiv administrators that will have first contact with new PRs. The list explains how to ensure the PR si following the standards for ecRxiv submissions, @@ -101,7 +101,10 @@ Option 1 is the preferred option. ### When the file renders and the app don't break -Then we can merge the PR to main. +Add as many coomments and suggestions as you feel relevent in the PR. +You can also use the *community review* issue template for this. +When alle your comments are resolved by the author, then we can merge the PR to main. + Immediately afterwards we create a stable copy of the HTML with the version number included in the name (INDICATORID_XXX_version_VVV_vvv; where XXX is the indicator ID number, and VVV and vv is the version number, before and after the perions, respectively).