Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

friction_method: WideBandExact in diabatic_mdef.jl uses the AndersonHolstein model instead of the inner 2x2 model #344

Open
reinimaurer1 opened this issue Jun 3, 2024 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@reinimaurer1
Copy link
Member

There is a bug in ClassicalMethods/diabatic_mdef.jl, line 65, function evaluate_friction!

In the WideBandExact case get_potential and get_derivative takes the wrong quantities. It passes quantities related to the AndersonHolstein model instead of related to the 2x2 "inner model". This has gone unnoticed so far as in the case when a Trapezoidal discretisation is used with the right value for the density of states, prefactors cancel and the coupling and derivatives come out right. In the GaussLegendre case, things go wrong.

Current Behaviour:

  • AndersonHolstein combined with a Trapezoidal bath and friction_method:WideBandExact gives correct results (assuming that WideBandExact is initialised with the DOS equal to $(nstates+1)/(bandmax-bandmin)$
  • AndersonHolstein combined with ShenviGaussLegendre and friction_method:WideBandExact goes wrong.

Expected Behaviour:

  • friction_method: WideBandExact shouldn't depend at all on the discretisation as it only requires the impurity potentials and $\Gamma$

TODO:

@reinimaurer1 reinimaurer1 added the bug Something isn't working label Jun 3, 2024
@reinimaurer1 reinimaurer1 self-assigned this Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant