You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There is a bug in ClassicalMethods/diabatic_mdef.jl, line 65, function evaluate_friction!
In the WideBandExact case get_potential and get_derivative takes the wrong quantities. It passes quantities related to the AndersonHolstein model instead of related to the 2x2 "inner model". This has gone unnoticed so far as in the case when a Trapezoidal discretisation is used with the right value for the density of states, prefactors cancel and the coupling and derivatives come out right. In the GaussLegendre case, things go wrong.
Current Behaviour:
AndersonHolstein combined with a Trapezoidal bath and friction_method:WideBandExact gives correct results (assuming that WideBandExact is initialised with the DOS equal to $(nstates+1)/(bandmax-bandmin)$
AndersonHolstein combined with ShenviGaussLegendre and friction_method:WideBandExact goes wrong.
Expected Behaviour:
friction_method: WideBandExact shouldn't depend at all on the discretisation as it only requires the impurity potentials and $\Gamma$
TODO:
change the behaviour such that WideBandExact friction only depends on quantities in the "inner model": AndersonHolstein.model
There is a bug in ClassicalMethods/diabatic_mdef.jl, line 65,
function evaluate_friction!
In the WideBandExact case
get_potential
andget_derivative
takes the wrong quantities. It passes quantities related to the AndersonHolstein model instead of related to the 2x2 "inner model". This has gone unnoticed so far as in the case when a Trapezoidal discretisation is used with the right value for the density of states, prefactors cancel and the coupling and derivatives come out right. In the GaussLegendre case, things go wrong.Current Behaviour:
Expected Behaviour:
friction_method: WideBandExact
shouldn't depend at all on the discretisation as it only requires the impurity potentials andTODO:
AndersonHolstein.model
The text was updated successfully, but these errors were encountered: