Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interoperability with cli_filter/user_defaults plugin #153

Open
jfolz opened this issue Nov 20, 2024 · 1 comment
Open

Interoperability with cli_filter/user_defaults plugin #153

jfolz opened this issue Nov 20, 2024 · 1 comment

Comments

@jfolz
Copy link

jfolz commented Nov 20, 2024

Hello Pyxis people,

We're currently investigating how to reduce the amount of boilerplate our users have to deal with. Allowing them to set custom defaults in $HOME/.slurm/default which are picked up by the cli_filter/user_defaults plugin is an interesting option. Pyxis' arguments, mostly container-image and container-mounts, are great candidates here.

Unfortunately, the plugin only deals with standard Slurm arguments, not those added by SPANK plugins. After scanning slurm_opt_t, srun_opt_t etc. I came to the conclusion that plugin-specific arguments are simply not accessible there. They seem to be buried somewhere deep inside srun. The only possible point of interaction I see is through manipulation of the job environment (or potentially slurm_opt_t->spank_job_env, though I don't know what that actually does), i.e., cli_filter/user_defaults could be patched to add some Pyxis-specific env vars to hold the defaults.

So I guess I have two questions:

  1. Did I overlook something, and this is actually very easy to achieve?
  2. What are the chances that Pyxis might add support for reading arguments from env vars like PYXIS_CONTAINER_IMAGE?

ps: Don't hesitate to close this if you feel it's a silly request/outside your jurisdiction/...

@flx42
Copy link
Member

flx42 commented Jan 17, 2025

Sorry for the delay!

What are the chances that Pyxis might add support for reading arguments from env vars like PYXIS_CONTAINER_IMAGE?

That seems totally reasonable, I will look into that when I have some cycles.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants