Pydantic 2+

[duvi86]

Hi,

I wanted to check when you would upgrade to Pydantic 2+ version. This is indeed a very much used library and there are quite some changes to operate to make it work. Thanks.

[nnansters]

Hey @duvi86 , our own code doesn't use a lot of Pydantic functionality apart from configuration files. It might be in some of our dependencies though.

I've not really thought about the upgrade up until now. Is there anything you need that relies on the update?

[duvi86]

Hi, This is just a compatibilité issue. As our core application is pydantic v2, we just can t import nannyml while this is a very interesting toolbox. Best regards

…

On Thu, 9 Nov 2023, 22:10 Niels, ***@***.***> wrote: Hey @duvi86 <https://github.com/duvi86> , our own code doesn't use a lot of Pydantic functionality apart from configuration files. It might be in some of our dependencies though. I've not really thought about the upgrade up until now. Is there anything you need that relies on the update? — Reply to this email directly, view it on GitHub <#331 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACYQPKTFXKASWRUHVEKNJHDYDVBDJAVCNFSM6AAAAAA6WJ45ZCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMBUGY4DSNRWHA> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[nnansters]

I see, that makes total sense. I've quickly ran an experiment and I already see one of our dependencies not being compatible with V2.

Maybe shuffling them into an optional dependency group (used for database stuff) could work around the issue.

We will also have to ensure that we don't force people using the library to move to Pydantic V2 as well.

I'll look into it as soon as possible.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[duvi86]

Hi This makes more sense to upgrade fully to v2 no? Thanks

…

On Tue, 9 Jan 2024, 06:11 stale[bot], ***@***.***> wrote: This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. — Reply to this email directly, view it on GitHub <#331 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACYQPKQAN4GPS3NVWL6Y7HLYNTGQFAVCNFSM6AAAAAA6WJ45ZCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOBSGQZDGMZQGA> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[nnansters]

Hey @duvi86 ,

haven't had the time yet to look further into this, sorry. It's still on our radar!

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[code4days]

Any update on this?

[nnansters]

Hey guys, sorry for being slow on this one. We have a rare spot of free time in the coming week, will be looking into this one. Updates soon to follow!

[nnansters]

PR #401 is up! New release should arrive in the coming days. Thanks for the patience!

[LieberzeitovaEliska]

Looking forward to the new release 🤩 (tried installing using the latest commit hash and it seems to be working as expected). Thanks for bringing the attention to this important issue. @nnansters, big up for finding the time to solve this! Thank you.

[nnansters]

Great news, thanks for testing!

And to everyone: thanks for the patience!

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.