Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pyproject too restrictive #431

Open
alex47ST3 opened this issue Dec 5, 2024 · 7 comments
Open

Pyproject too restrictive #431

alex47ST3 opened this issue Dec 5, 2024 · 7 comments
Assignees
Labels
enhancement New feature or request

Comments

@alex47ST3
Copy link

Motivation: describe the problem to be solved
I am having a hard time trying to integrate nanny-ml in my library, basically I have conflicts with many different libraries, like dotenv, numpy, pydantic, pandas, scipy etc. I get that for some not widely used library it might be tricky, but I think that for the basic ones latest versions should be available.

Describe the solution you'd like
Maybe open the versions in your pyproject.toml or update the code to make sure it's able to run with more recent versions of all these basic libraries

Describe alternatives you've considered
I tried downgrading some libraries, but to be fair using such old versions of these libraries is not something we are very happy with, as we aren't able to use the latest features plus it could be a security risk

@alex47ST3 alex47ST3 added the enhancement New feature or request label Dec 5, 2024
@nnansters
Copy link
Contributor

Hey @alex47ST3 ,

yes to everything you mentioned. We've scheduled time to work on unpinning and updating the dependencies next week.
If there are any specific (major) versions of dependencies you'd like to see, definitely let us know.

Thanks for taking the time to try us out and log an issue!

@alex47ST3
Copy link
Author

Thank you for the quick response @nnansters! Nanny is an amazing tool and it's pity to not be able to use it because some dependency conflict 😕

Taking a look to the pyproject and without about absolutely idea of the how it works internally (so take it with caution), I would suggest allowing minor versions in the following :

  • python-dateutil
  • scikit-learn
  • joblib
  • matplotlib
  • plotly
  • scipy
  • seaborn
  • kaleido
  • pyarrow
  • gcsfs
  • pydantic
  • rich
  • click
  • PyYAML
  • Jinja2
  • sqlmodel
  • psycopg2-binary
  • python-dotenv
  • types-pyyaml
  • types-python-dateutil

And major for:

  • numpy
  • pandas
  • lightgbm

Thanks a lot again!

@nnansters
Copy link
Contributor

Cheers! We'll take that into account. Also we have way too many dependencies (but we're solving that as we speak)!

@canoadri
Copy link

Hi @nnansters, any update on this? This is becoming a blocking issue for us.

@nnansters
Copy link
Contributor

Starting on it right now!

@nnansters
Copy link
Contributor

Take a look at #433 !

@alex47ST3
Copy link
Author

thank you, but I believe that now nannyml is even more restrictive as that pyproject in #433 needs even newer version of some fundamental libraries.

For example it will only allow pandas >=2.2, <3.0, and in many libraries pandas 1 is still the needed version, so imo this will make very complicated to adopt NannyML.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants