Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial feedback #10

Closed
sofer opened this issue Apr 7, 2015 · 3 comments
Closed

Initial feedback #10

sofer opened this issue Apr 7, 2015 · 3 comments
Assignees

Comments

@sofer
Copy link

sofer commented Apr 7, 2015

I love this.

Here are some minor comments:

  1. "students of Founders & Coders 8 week coding Academy."

perhaps change to "students of courses at Founders & Coders", just because I suspect we will want to use this for our weekend courses, too.

  1. git branch new-branch

To a novice, it may not be clear whether new-branch is a command or the name of something. my-new-branch might be more obvious.

  1. Might be worth noting the difference between:

git clone https://github.com/NataliaLKB/learn-git-basics.git

and:

git@github.com:NataliaLKB/learn-git-basics.git

which beginners could usefully be made aware of.

  1. Might be worth nothing the difference between git push, git push origin and git push origin master. See http://stackoverflow.com/questions/12462481/what-is-the-difference-between-git-push-origin-and-git-push-origin-master and https://www.kernel.org/pub/software/scm/git/docs/git-push.html#_examples
  2. Under "Merging Changes with Master" at the end, you may want to say something about comparing across forks, and about base fork and head fork otherwise there is a danger that you will get loads of pull requests into your original repo.
@NataliaLKB
Copy link
Owner

@sofer thanks for this! Great feedback.

@NataliaLKB NataliaLKB self-assigned this Apr 7, 2015
@NataliaLKB NataliaLKB mentioned this issue Apr 12, 2015
@NataliaLKB
Copy link
Owner

@sofer #26 answers the first part of your feedback.

Regarding git@github.com:NataliaLKB/learn-git-basics.git I would like to cover this, ssh keys, and forks in a FAC section. see #20.

Lastly, regarding the differences between the git push * commands. I don't think this is crucial for beginners to know. I think it could work in a further resources section #24

tormod17 pushed a commit to tormod17/learn-git-basics that referenced this issue Sep 13, 2015
@NataliaLKB
Copy link
Owner

Closing a I think I dealt with most of this already

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants