Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use of Global variables in $V, $L, $M, $P node package #6

Open
jondayft opened this issue Apr 20, 2016 · 6 comments
Open

Use of Global variables in $V, $L, $M, $P node package #6

jondayft opened this issue Apr 20, 2016 · 6 comments
Milestone

Comments

@jondayft
Copy link

Is there a reason that $V ,$L, $M, $P are in global scope? This is currently causing issues when testing with mocha, so we are having to add these to the mocha --globals option. Since everything is being exported it would seem like the attachment to global variable isn't required.

I assume there may be a very good reason for this but doesn't seem like best practice?

@alexandrebodin
Copy link

+1

1 similar comment
@krazik
Copy link

krazik commented May 30, 2016

+1

@tommedema
Copy link

+1

1 similar comment
@oveddan
Copy link

oveddan commented Dec 6, 2016

+1

@connor4312
Copy link
Contributor

Also: the global addition of Math.sign

@connor4312
Copy link
Contributor

Hi all, I recently signed on as a maintainer of this project. I'll slate this for a stable 1.0.0 release 😄

@connor4312 connor4312 added this to the 1.0.0 milestone Jan 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants