Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement RPCv6 #458

Closed
22 tasks done
rianhughes opened this issue Nov 8, 2023 · 0 comments
Closed
22 tasks done

Implement RPCv6 #458

rianhughes opened this issue Nov 8, 2023 · 0 comments
Labels
Milestone

Comments

@rianhughes
Copy link
Contributor

rianhughes commented Nov 8, 2023

Starknet RPCv060-rc1

(Note: this issue was originally created for v0.6.0-rc0. The main changes for rc1 have to do with the transaction v3 types, RESOURCE_BOUNDS_MAPPING, and EXECUTION_RESOURCES. Should double check this issue updates to rc-1).

(Note: We later decided to support rc5. This upgrade is broken down into two PRs 475, 486)

The main changes involve 1) implementing V3 transactions, and 2) updating the fields in various types/structs.

note: We still need to add e2e tests for v3 transactions (note:we are putting this of for a patch given difficulties of working with integration network atm)

Sub-issues:

Update Readme:

Update TestSpecVersion to rc4

Upgrade to RC4:

Tests -

Transaction - types

Various non-transaction types:

Changes to the spec that don't require changes to starknet.go (eg spec had error, that is now fixed, and matches starknet.go)

  • ORDERED_EVENT, ORDERED_MESSAGE type should be int
  • Update error message in BLOCK_NOT_FOUND error
  • PENDING_BLOCK_HEADER certain fields should not be present (the not-required fields are not defined in the starknet.go struct, implicitly satisfying this condition)

Finally:

  • Double check all changes match the rc-5 spec
@rianhughes rianhughes moved this to 🔖 To do in [Nubia] Starknet.go Nov 8, 2023
@rianhughes rianhughes added this to the rpcv6 milestone Nov 8, 2023
@rianhughes rianhughes removed this from the rpcv6 milestone Nov 8, 2023
@stranger80 stranger80 added this to the rpcv6 milestone Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: ✅ Done
Development

No branches or pull requests

3 participants