Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build failure: envision-unwrapped #372527

Closed
ToasterUwU opened this issue Jan 10, 2025 · 6 comments
Closed

Build failure: envision-unwrapped #372527

ToasterUwU opened this issue Jan 10, 2025 · 6 comments
Labels
0.kind: build failure A package fails to build

Comments

@ToasterUwU
Copy link
Member

Steps To Reproduce

Steps to reproduce the behavior:

  1. Set programs.envision.enable to true
  2. Apply config, which builds envision

Build log

Build Log
Using versionCheckHook
Running phase: unpackPhase
@nix { "action": "setPhase", "phase": "unpackPhase" }
unpacking source archive /nix/store/va9c8fxm3vggwsgaa9aznvrqkplhl36y-envision-e69a7a9
source root is envision-e69a7a9
Executing cargoSetupPostUnpackHook
Finished cargoSetupPostUnpackHook
Running phase: patchPhase
@nix { "action": "setPhase", "phase": "patchPhase" }
applying patch /nix/store/k575y7vmli70yyjz1m3fpb7hbm4xdlw1-support-headless-cli.patch
patching file Cargo.lock
patching file Cargo.toml
patching file meson.build
patching file src/constants.rs.in
patching file src/main.rs
Hunk #2 succeeded at 84 (offset 1 line).
Hunk #3 succeeded at 122 (offset 1 line).
patching file src/ui/cmdline_opts.rs
Hunk #1 FAILED at 1.
Hunk #2 FAILED at 8.
Hunk #3 succeeded at 46 (offset 13 lines).
Hunk #4 succeeded at 62 (offset 13 lines).
Hunk #5 succeeded at 102 with fuzz 2 (offset 18 lines).
2 out of 5 hunks FAILED -- saving rejects to file src/ui/cmdline_opts.rs.rej

Additional context

Metadata

  • system: "x86_64-linux"
  • host os: Linux 6.6.69, NixOS, 25.05 (Warbler), 25.05.20250104.8f3e1f8
  • multi-user?: yes
  • sandbox: yes
  • version: nix-env (Nix) 2.24.11
  • nixpkgs: /nix/store/khbvilmsrv4l69nwd52h27j1mp44a0xi-source

Notify maintainers

@Pandapip1
@Scrumplex


Note for maintainers: Please tag this issue in your PR.


Add a 👍 reaction to issues you find important.

@ToasterUwU ToasterUwU added the 0.kind: build failure A package fails to build label Jan 10, 2025
@Pandapip1
Copy link
Contributor

I was wondering whether or not I should bring that patch out of the module. I'll work on fixing this.

@Pandapip1
Copy link
Contributor

Pandapip1 commented Jan 10, 2025

Never mind, the patch isn't applied by the module? I know that I have a module somewhere that does that and it's cursed and I should really make the patched derivation its own package so it gets built by nixpkgs-review. I'll fix the patch, and see how it was possible for this to get broken in the first place.

@Pandapip1
Copy link
Contributor

Pandapip1 commented Jan 10, 2025

The plot thickens. I can't reproduce the failing derivation, even when enabling the envision NixOS module. It looks like you're on a fairly recent nixpkgs; can you update to the latest nixpkgs unstable just to make sure it wasn't a one-off regression?

I checked the blame for the file; while I've submitted PRs against envision recently, none of them have been merged. The last version bump was a month ago, and the patch was added since then, iirc. Nothing should have changed to cause the patch to not apply.

@Scrumplex
Copy link
Member

This could be from nixpkgs-xr.

Currently the update workflow has been broken for a few days so I wasn't able to catch this.

@ToasterUwU
Copy link
Member Author

Ohh yeah my bad, i forgot i have the nixpkgs-xr NixOS module enabled which also has an option like that and replaces it

@ToasterUwU
Copy link
Member Author

Yeah, just disabled it and tadaaaa it works again, sorry for the unneeded issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.kind: build failure A package fails to build
Projects
None yet
Development

No branches or pull requests

3 participants