Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enableStrictShellChecks breaks Renovate tests #373166

Open
l0b0 opened this issue Jan 12, 2025 · 1 comment
Open

enableStrictShellChecks breaks Renovate tests #373166

l0b0 opened this issue Jan 12, 2025 · 1 comment
Labels
0.kind: bug Something is broken

Comments

@l0b0
Copy link
Contributor

l0b0 commented Jan 12, 2025

Describe the bug

Steps to reproduce

Steps to reproduce the behavior:

  1. Check out nixos/renovate: Fix ShellCheck issue #373131
  2. Add systemd.enableStrictShellChecks = true; to the machine config in nixos/tests/renovate.nix
  3. nix-build --attr nixosTests.renovate

Actual behavior

The test run hangs.

Expected behavior

The test should proceed as normal.

Metadata

  • system: "x86_64-linux"
  • host os: Linux 6.12.8, NixOS, 25.05 (Warbler), 25.05.20250108.bffc22e
  • multi-user?: yes
  • sandbox: yes
  • version: nix-env (Nix) 2.24.11
  • channels(root): ""
  • nixpkgs: /nix/store/v0g0bxsd5gw6k0jz2855f8h7l1218925-source

Notify maintainers

@Scrumplex


Note for maintainers: Please tag this issue in your PR.


Add a 👍 reaction to issues you find important.

@l0b0 l0b0 added the 0.kind: bug Something is broken label Jan 12, 2025
@Scrumplex
Copy link
Member

Scrumplex commented Jan 12, 2025

Boot fails because of the test instrumentation sourcing /etc/profile. Enabling strict checks sets Bash's nounset option, which fails fatally for most profile scripts currently.

Edit: See #349579 for a workaround

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.kind: bug Something is broken
Projects
None yet
Development

No branches or pull requests

2 participants