Project Notes

[martypdx]

(Feel free to close this issue, I just wanted to use markdown :)

Great project, really nice job managing things on the backend. Promise chains, models, routes, project org all really quite good.

Here are notes for suggestions I took while review the code:

• Make sure not to check .env files into github. You might want to revoke/change they KEY if it might be bad for someone to get ahold of it.
• Testing was good, would have liked to see more clear user auth API workflow tests.
• Cache repeatedly accessed property values. For example:
  • here put a[i] into variable.
  • here put result.GoodreadsResponse.search[0] in variable
• For root router paths, you can omit the path param. Instead of:
  .get('', (req,res,next) => {
  use:
  .get((req,res,next) => {
• For Series get all, seems like you migh not have needed all the installment data. If it is needed, you still have duplication with the get by id, perhaps it should have been a model method populateInstallments?
• Not sure why this route in the series module.
• Looks like two ways to add a user, signup and users. Also, looks like I could modify password inadvertently using the users routes. Don't expose all data unless there's a need.