Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Distributor as own package #5

Open
genofire opened this issue Sep 6, 2021 · 5 comments · Fixed by #10
Open

Distributor as own package #5

genofire opened this issue Sep 6, 2021 · 5 comments · Fixed by #10

Comments

@genofire
Copy link
Contributor

genofire commented Sep 6, 2021

An own package of github.com/karmanyaahm/np2p_linux/distributor would be nice, maybe under:
github.com/UnifiedPush/go_dbus_distributor / unifiedpush.org/go/dbus_distributor

@karmanyaahm
Copy link
Member

Having it inside np2p is very convenient for development. Apart from that, it's just a naming thing and importing unifiedpush.org/go/dbus_distributor would functionally be the same as importing (the current-new URL) unifiedpush.org/go/np2p_dbus/distributor.

Please let me know if there's a different reason to split than (the only ones I understand) naming conventions and/or separation of repo issues and stuff.

@genofire
Copy link
Contributor Author

genofire commented Sep 7, 2021

Just beautiful import and maybe just less loading of go.mods, till compile

@genofire
Copy link
Contributor Author

genofire commented Sep 12, 2021

Does i make someting wrong?

go get -u unifiedpush.org/go/dbus/distributor                                              
go get: module unifiedpush.org/go/dbus/distributor: git ls-remote -q origin in /home/genofire/pkg/mod/cache/vcs/dd9daf5c8fc3043c18a0771d353f3cfc8f061e4df6f7a99dcd6adef111a3184f: exit status 128:
	remote: Not Found
	fatal: repository 'https://github.com/NoProvider2Push/dbus/distributor.git/' not found

@karmanyaahm
Copy link
Member

karmanyaahm commented Sep 12, 2021

Oh oops I put the url in the documentation the wrong way

@karmanyaahm
Copy link
Member

karmanyaahm commented Sep 12, 2021

I'll undo this change for now and see how to solve it later

golang/go#33562 (comment)

@karmanyaahm karmanyaahm reopened this Sep 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants