-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can't install with Firefox 60 #117
Comments
Same issue. Endless validating when using link from Chrome store (See attachments) Preparing to download and install when installing extension from https://chrome.google.com/webstore And finally, I have downloaded CRX extension https://biblsoft.ru/windows/internet/ad-blockers/168-adblock-plus and tried to install it - no results: |
Same here. Trying to install the Google Dictionary add-on, but it's just been endlessly checking |
any news about an update? |
I've emailed the dev to ask him about this extension and bug. He had been far too busy recently to look at CSF but is now looking into this bug as it's not even working for him when he tested it. |
Thanks very much @Two-Tone for reaching out. I'm taking a look right now and finding a fetch is now getting blocked for "Cross-Origin Request". This didn't happen before. Am looking into it. |
This looks like a duplicate of #113 |
Thanks @znmeb yep it is. I hope to knock both of these bugs out. For any extension devs out there, it seems the problem is I am not able to do a |
Thanks @QWERTYUIOPYOZO - I actually just got confirmation from a Mozilla engineer that they have blocked And for the The new extension system of Firefox seems to be turning into more trash day by day. And also less cross-browser day by day. Both against the reasons for WebExtensions. It's really assumption of me to say this, but it just feel like "block fetch to addons.mozilla.org" is not a real solution to whatever issue they were trying to fix. Similar to blocking content scripts on AMO wasn't a solution for the issue "they can install addons from AMO". I feel if they wanted to fix they could have. Possibly identify where the script was executing from and disallow it from installing an extension. If I recall right, content scripts are in sandboxes and its easy to identify the sandbox doesn't belong to a web page. They saw Google Chrome blocked content scripts on CWS so they just followed suit probably, thinking if Google did it's probably the best/only solution. |
Did they explain why they blocked it?
…On Mon, May 21, 2018 at 3:34 PM, Noitidart ***@***.***> wrote:
Thanks @QWERTYUIOPYOZO <https://github.com/QWERTYUIOPYOZO> - I actually
just got confirmation from a Mozilla engineer that they have blocked fetch
to https://addons.mozilla.org/. Even the https://addons.mozilla.org/api/
end points do not have CORs headers. We would have to ask the AMO engineers
to add CORS headers.
And for the fetch to https://addons.mozilla.org/ I'll have to ask people
to manually input the user token and password as I can't inject content
scripts into this.
The new extension system of Firefox seems to be turning into more trash
day by day. It's real generic of me to say this, but it just feels like
"block fetch to addons.mozilla.org" is not a real solution to whatever
issue they were trying to fix.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#117 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AEJES8Um3AG1rYZwrV19jXmLrBEjbY4gks5t0yTJgaJpZM4T4QdZ>
.
|
Nope no explanation. I asked for a bug maybe they didn't see my comment yet. Hopefully they will link me. |
Well that's annoying. |
Got explanation "No. We don't block fetch, we just don't grant special permissions for AMO based on add-on permissions anymore." So this means the cross origin special permission doesn't apply to AMO. So fetch isn't "blocked" but it has been disabled from succeeding. |
Come on Mozilla. Same difference. |
Just a thought, I know that you run a server to host the compatibility forum. |
That could get expensive and it's a bit much to expect him to do it for
free.
…On Mon, May 21, 2018 at 4:07 PM, QWERTYUIOPYOZO ***@***.***> wrote:
You run a server to host the compatibility forum.
Is there a reason you don't just have the extension send the URL of the
chrome extension to the server where it can be temporarily downloaded to
the server, then uploaded to AMO and signed through a single
purpose-created account (which you would know the API key for), and then
stored on the server for the client to download. If it works, it would
eliminate the need for the user to have an AMO account, upload/download the
extension multiple times and convert extensions that have already been
converted by other users.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#117 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AEJES8tOwhJzjENl9gjOlzkQ9BZUjG7eks5t0yylgaJpZM4T4QdZ>
.
|
Hmm. It would be much easier if Mozilla simply integrated this straight into firefox. |
I used to use a single-purpose account, but then the addon reviewers rejected it and required me to use user accounts. Maybe I can ask them, due to the changes if I can go back to single purpose account and hard code in account token for signing. That server way is for sure the way to go. I already have a server for the forum. Just need to set it up to do all the signing now too. Yes totally. It would be very much easier if Mozilla just let me do it in the extension. Thanks @Two-Tone for that comment, really appreciate it. That's the reason I got busy, with work. I get extremely little out of this. I have a donation sign up, but over the years, to date I got < ~$100. While it would be nice to get more, feedback and happy users means a lot to me so I keep going. :) |
It's not clear to me from reading this, is it possible to work around this temporarily by downgrading my firefox? |
@bluenote73 it probably will work. I'm not sure in what version they disabled fetch to AMO. I am going to try to set up my server to do this stuff now. |
I'm pretty sure it was 60 - this just started failing for me after the update from 59 to 60. |
@bluenote73 @znmeb Installing 59.0.3 to a different dir just as a workaround seems to do it for now. The hassle is that you have to make sure that install won't update, and will sync CSF/extensions with your current one. |
This problem seems quite ironic, considering webextensions' goal is to prevent addons from breaking when Firefox is updated. |
@CRC-Mismatch I only had one extension that needed this tool, and they finally made an XPI that will install on Firefox 60. So I don't need a workaround any more. |
Agreed with QWERTYUIOPYOZO: it's ridiculous that one of the key 'benefits' of WEs seems to have been undermined by Mozilla. |
Hi guys, see my workaround highlighted here: |
Any new news on this item, maybe from Firefox? Edit - might i suggest a note be added to the Firefox addon page to warn new users and old what's going on? There's significant carnage and confusion there. |
For anyone suffering with this, I worked around by switching to Yandex mobile browser on Android which supports native chrome extensions. |
After Firefox update to latest (60) version, the Chrome Store Foxified don't install anything.
It stay ever on "Checking AMO Credentials" and don't go on.
The text was updated successfully, but these errors were encountered: