Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotkey Registration #69

Open
noureddin opened this issue Sep 21, 2016 · 9 comments
Open

Hotkey Registration #69

noureddin opened this issue Sep 21, 2016 · 9 comments

Comments

@noureddin
Copy link
Contributor

This message appears every time I install the plugin, or enable it. But it's not localized. I think it should be localized in a next version. :)

832

Also, I wish I can change the plugin hotkey instead of the system hotkey.

@Noitidart
Copy link
Owner

Thanks for this catch! I need to localize it more to tell them to avoid seeing this error they can "disable the system hotkey" from the options page.

Only one app is allowed to have the hotkey registered at any time.

@Noitidart
Copy link
Owner

@noureddin If your go to your global system settings and unset the "Print Screen" button, then this should work.

I implemented changing hotkey in Topick here - https://addons.mozilla.org/en-US/firefox/addon/topick/ - I need to bring that to NativeShot.

Noitidart added a commit that referenced this issue Sep 21, 2016
* Localized hotkey error message per #69
* Also made the error message non-obtrusive but using notification api
rather then prompt box
* Clicking the panel opens the options api

* Per @insolor and @AdmiralAnimE I added Bulgarian and Russian to
non-text-transform group -
#47 (comment)
and
#47 (comment)
@Noitidart
Copy link
Owner

I just added the localized version of this to Babelzilla. I also made this alert box non-obtrusive:

I'll bring in the "Topick" feature of changing the plugin hotkey in a future version as its a pretty big pull, I haven't modularized it yet.

@noureddin
Copy link
Contributor Author

Thanks! ♥ I just finished translating the new strings. But this update doesn't seem to be included in the BabelZilla build; it still has the old message.

@Noitidart
Copy link
Owner

Will merge it right now and upload for you here 10minutes please. Thank you soooo very much for your awesome teamwork. It really feels awesome! :)

@Noitidart
Copy link
Owner

Here we are, attached is updated xpi :) Excuse the delay please
nativeshot-v1.12b.rev43.zip

@noureddin
Copy link
Contributor Author

No problem at all! :)
Great! Now I'll close this and #67. Thank you! ♥

@Noitidart
Copy link
Owner

Noitidart commented Sep 23, 2016

Barakallahfi sir! I still should update this so users can change the hotkey though ( as implemented in topick addon - https://addons.mozilla.org/en-US/firefox/addon/topick/ ). Maybe a non-translation issue though huh? So another issue for that one?

@noureddin
Copy link
Contributor Author

I think, yes, it's better to have it in a separated issue; it's my mistake in the first place to put both of them in a single issue. But I think there is no problem to reopen the issue. :D And I'll change its title to reflect the content.

@noureddin noureddin reopened this Sep 23, 2016
@noureddin noureddin changed the title Localized Hotkey Registration Error message Hotkey Registration Sep 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants