Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make hardhat-chai-matchers compatible with hardhat-viem / library-agnostic #4874

Open
schaable opened this issue Feb 15, 2024 · 5 comments
Open
Labels
area:chai-matchers area:hardhat-viem status:ready This issue is ready to be worked on type:research Get the information necessary to implement or decide something

Comments

@schaable
Copy link
Member

The hardhat-chai-matchers plugin is currently only compatible with hardhat-ethers. This issue aims to see if there's interest in making it work with hardhat-viem and other Ethereum libraries. Please upvote or comment if you think this would be an useful feature.

@schaable schaable added area:chai-matchers type:research Get the information necessary to implement or decide something area:hardhat-viem labels Feb 15, 2024
@github-actions github-actions bot added the status:ready This issue is ready to be worked on label Feb 15, 2024
@github-project-automation github-project-automation bot moved this to Backlog in Hardhat Feb 15, 2024
@dennis-gonzales
Copy link

viem is great imo, hopefully we can support this when able.

@andreujuanc
Copy link

Would love to have this! much more cleaner with the matchers!

@mwawrusch
Copy link

To add to that, hardhat-chain-matchers now uses the chaiAsPromised library which is not maintained anymore and is incompatible with chai 5. So it would make sense to upgrade / replace that as well while getting viem going.

@petdomaa100
Copy link

+1

@johnpm-12
Copy link

I put up a PR to add a viem specific package for chai matchers: #5252

In case anyone finds it useful, in the meantime, I deployed it here: https://www.npmjs.com/package/hardhat-chai-matchers-viem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:chai-matchers area:hardhat-viem status:ready This issue is ready to be worked on type:research Get the information necessary to implement or decide something
Projects
Status: Backlog
Development

No branches or pull requests

6 participants