Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lsasagas code action preview crashes tabuflilne with invalid buffer id. #285

Open
Nirajgns opened this issue May 20, 2024 · 11 comments
Open

Comments

@Nirajgns
Copy link

....local/share/nvim/lazy/ui/lua/nvchad/tabufline/utils.lua:37: Invalid buffer id: 118
stack traceback:
^I[C]: in function 'buf_name'
^I....local/share/nvim/lazy/ui/lua/nvchad/tabufline/utils.lua:37: in function 'gen_unique_name'
^I....local/share/nvim/lazy/ui/lua/nvchad/tabufline/utils.lua:51: in function 'style_buf'
^I...ocal/share/nvim/lazy/ui/lua/nvchad/tabufline/modules.lua:74: in function <...ocal/share/nvim/lazy/ui/lua/nvchad/tabufline/modules.lua:60>
^I...ocal/share/nvim/lazy/ui/lua/nvchad/tabufline/modules.lua:117: in function <...ocal/share/nvim/lazy/ui/lua/nvchad/tabufline/modules.lua:107>
^I[C]: in function 'nvim_exec2'
^Ivim/_editor.lua: in function 'cmd'
^I.../share/nvim/lazy/nvim-notify/lua/notify/service/init.lua:63: in function 'push'
^I...ocal/share/nvim/lazy/nvim-notify/lua/notify/instance.lua:77: in function <...ocal/share/nvim/lazy/nvim-notify/lua/notify/instance.lua:41>
^I...e/nvim/lazy/noice.nvim/lua/noice/view/backend/notify.lua:169: in function '_notify'
^I...e/nvim/lazy/noice.nvim/lua/noice/view/backend/notify.lua:199: in function 'show'
^I...local/share/nvim/lazy/noice.nvim/lua/noice/view/init.lua:155: in function <...local/share/nvim/lazy/noice.nvim/lua/noice/view/init.lua:153>
^I[C]: in function 'xpcall'
^I...local/share/nvim/lazy/noice.nvim/lua/noice/util/call.lua:149: in function <...local/share/nvim/lazy/noice.nvim/lua/noice/util/call.lua:134>
^I...local/share/nvim/lazy/noice.nvim/lua/noice/view/init.lua:162: in function 'display'
^I.../share/nvim/lazy/noice.nvim/lua/noice/message/router.lua:223: in function <.../share/nvim/lazy/noice.nvim/lua/noice/message/router.lua:156>
^I[C]: in function 'xpcall'
^I...local/share/nvim/lazy/noice.nvim/lua/noice/util/call.lua:149: in function <...local/share/nvim/lazy/noice.nvim/lua/noice/util/call.lua:134>
^I[C]: in function 'pcall'
^I...local/share/nvim/lazy/noice.nvim/lua/noice/util/init.lua:146: in function ''
^Ivim/_editor.lua: in function ''
^Ivim/_editor.lua: in function <vim/_editor.lua:0>

@siduck siduck transferred this issue from NvChad/NvChad May 20, 2024
@siduck
Copy link
Member

siduck commented May 22, 2024

looks like a bug from lspsaga's end

@siduck
Copy link
Member

siduck commented May 22, 2024

vim.api.nvim_create_autocmd("BufAdd", {
  callback = function(args)
    if vim.bo[args.buf].buflisted then
      print(args.buf)
    end
  end,
}) 

image

So when i go through the actions window and when cursor is on 3rd , then the below window shows up

and then the above autocmd gets triggered, i dont see any buflisted buffer and yet it gets triggered!

@glepnir any idea?

@glepnir
Copy link

glepnir commented May 22, 2024

action preview buffer is not listed.

@siduck
Copy link
Member

siduck commented May 22, 2024

action preview buffer is not listed.

yes i know, but try the autocmd, it still prints buf number cuz the buffer is listed, so weird

@glepnir
Copy link

glepnir commented May 22, 2024

can close . i had push a commit for fix. forget set it.

@siduck siduck closed this as completed May 22, 2024
@siduck
Copy link
Member

siduck commented Jul 14, 2024

can close . i had push a commit for fix. forget set it.

its happening again, weird

@KevinNitroG
Copy link
Contributor

can close . i had push a commit for fix. forget set it.

Good day @glepnir! It seems the issue still hasn't been resolved. Could you please take another look at it?

@siduck
Copy link
Member

siduck commented Dec 19, 2024

no longer facing this issue. seems like he has fixed it!

@siduck siduck closed this as completed Dec 19, 2024
@siduck siduck reopened this Jan 8, 2025
@siduck
Copy link
Member

siduck commented Jan 8, 2025

simplescreenrecorder-2025-01-08_11.55.00.mp4

@glepnir i still get this issue, but only for some files, weird. does lspsaga ignore buf events? i have no idea its buffers sneak through my bufferline's function ( which only filters listed buffers )

@glepnir
Copy link

glepnir commented Jan 8, 2025

emm I have been busy with the work of ins-completion in vim/neovim core. So I haven't maintained the plugin for a long time. The new lspsaga refactoring is in progress :)

@siduck
Copy link
Member

siduck commented Jan 8, 2025

emm I have been busy with the work of ins-completion in vim/neovim core. So I haven't maintained the plugin for a long time. The new lspsaga refactoring is in progress :)

oh all good man, Thanks for all your work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants