Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Bulk FileFormat should knows requested attributes during read path #196

Open
LesTR opened this issue Feb 19, 2021 · 0 comments

Comments

@LesTR
Copy link
Contributor

LesTR commented Feb 19, 2021

Currently we have this signature in FileFormat interface

Reader openReader(Path path, EntityDescriptor entity) throws IOException;

Which reads all attributes stored in path and then it is filtered by BlogLogReader just for requested.

This solution can be suboptimal for some FileFormats (eq parquet), where we can use for example push down filters and read just block which contains requested attributes.

We should probably pass list of requested attributes directly into FileFormat which allows to read file more effectively.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant