-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
proxima-core jar file contains unshaded dependencies #289
Comments
The typesafe config is part of the API (ConfigRepository takes config), shading it can be possibility, but it would break current code. Can you use the same version of typesafe config as is used by the core? Regarding com.google, that looks like a bug (errorprone, thirdparty). |
See datadrivencz#735 |
It would make sense to me to declare non-shade-relocated dependencies in POM ( and exclude from shaded JAR ) so they are a) directly visible to dev as to what is being used and b) let consumers of library resolve version conflicts via their build tools |
That makes sense. It would require some tools checking the API surface, so that the final jar actually contains only classes from |
…some unwanted exports from core
Should be fixes with gradle build, see here. Might mot be applied to all io modules consistently yet. |
Current version
0.9.0
of the library produces JAR file which containscom.typesafe.config
,com.google.*
which causes runtime issues for the consumers of this library due to classpath conflicts. Please relocate/shade/rename these packages. ThanksThe text was updated successfully, but these errors were encountered: