Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proxima-core jar file contains unshaded dependencies #289

Open
RadoBuransky opened this issue Sep 30, 2022 · 5 comments
Open

proxima-core jar file contains unshaded dependencies #289

RadoBuransky opened this issue Sep 30, 2022 · 5 comments

Comments

@RadoBuransky
Copy link

Current version 0.9.0 of the library produces JAR file which contains com.typesafe.config, com.google.* which causes runtime issues for the consumers of this library due to classpath conflicts. Please relocate/shade/rename these packages. Thanks

@je-ik
Copy link
Collaborator

je-ik commented Oct 26, 2022

The typesafe config is part of the API (ConfigRepository takes config), shading it can be possibility, but it would break current code. Can you use the same version of typesafe config as is used by the core?

Regarding com.google, that looks like a bug (errorprone, thirdparty).

je-ik added a commit to datadrivencz/proxima-platform that referenced this issue Oct 26, 2022
@je-ik
Copy link
Collaborator

je-ik commented Oct 26, 2022

See datadrivencz#735

@JozoVilcek
Copy link
Contributor

JozoVilcek commented Oct 26, 2022

It would make sense to me to declare non-shade-relocated dependencies in POM ( and exclude from shaded JAR ) so they are a) directly visible to dev as to what is being used and b) let consumers of library resolve version conflicts via their build tools

@je-ik
Copy link
Collaborator

je-ik commented Oct 26, 2022

That makes sense. It would require some tools checking the API surface, so that the final jar actually contains only classes from cz.o2.proxima.* and all the rest would be excluded from shade. It would also require to publish the dependency-reduced.pom, which I'm not sure if we do now.

je-ik added a commit to datadrivencz/proxima-platform that referenced this issue Nov 1, 2022
@je-ik
Copy link
Collaborator

je-ik commented Jul 31, 2023

Should be fixes with gradle build, see here. Might mot be applied to all io modules consistently yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants