Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transfer of maintainer #96

Open
rsbivand opened this issue Oct 4, 2024 · 41 comments
Open

Transfer of maintainer #96

rsbivand opened this issue Oct 4, 2024 · 41 comments

Comments

@rsbivand
Copy link
Collaborator

rsbivand commented Oct 4, 2024

@florisvdh @VLucet @hellik @veroandreo @petrasovaa @stevenpawley I feel that the demise of grass-dev as a digested mailing list makes this the right point in time to transfer maintenance: https://lists.osgeo.org/pipermail/grass-stats/2024-October/001883.html and https://lists.osgeo.org/pipermail/grass-dev/2024-October/096368.html. I'm grateful to Steven for responding - how should we proceed?

@florisvdh
Copy link
Collaborator

My work on the natural environment in Flanders right now makes it difficult to also adopt maintenance of rgrass, and this is probably not going to change the coming years (which is BTW also a happy and useful evolution since just one year). So I'm very happy with Steven's response. I will of course still follow the repo and will be happy to keep contributing at times.

@petrasovaa
Copy link
Contributor

Would it make sense to transfer the repo under r-spatial? I see Steven has Rsagacmd under his account, but in terms of sustainability and visibility, r-spatial seems better, no?

@rsbivand
Copy link
Collaborator Author

rsbivand commented Oct 4, 2024

Perhaps, let's take things a step at a time. qgisprocess and link2GI and others are there already, so it should be possible.

@stevenpawley
Copy link
Member

stevenpawley commented Oct 4, 2024 via email

@rsbivand
Copy link
Collaborator Author

rsbivand commented Nov 2, 2024

@stevenpawley Thanks so much for converting to roxygen in #97 ! I've checked locally with R 4.4.1 and today's R-devel on GRASS 8.4.0 (and GDAL 3.10.0rc3), all OK. I regenerated the online docs with pkgdown too (rsbivand@ef72593). I bumped the version number and updated DESCRIPTION.

@rsbivand
Copy link
Collaborator Author

@stevenpawley Should we aim to transfer maintainer and submit when CRAN comes back in early January? We'd also need to transfer ownership of this repo, and regenerate docs at your github account. A next step once that is done would be to ask r-spatial.

Alternatively, we could ask them first, including Rsagacmd at the same time.

There is was a NO_REMAP problem in C++ code in terra, which would need resolving first - the current github HEAD on master is clean (checked), so I expect an early submission.

@stevenpawley
Copy link
Member

Hi Roger,

Early January works for me, although I like the idea of moving to r-spatial (and Rsagacmd as well) - maybe this can all be done in one step, before submitting to CRAN?

I wonder - would it make sense for rgrass to reside in the OSGEO GitHub organization directly? Other than GRASS itself, there is a growing number of GRASS-related repos in there, including tutorials, workshop-related repos, etc.

Also, very soon, I'll try and finish a pull request that I've been working on to get rgrass running with a basic test suite in GitHub Actions, testing against some LTS ubuntu versions and the GRASS releasebranch Docker image.

@rsbivand
Copy link
Collaborator Author

Hi Steven,

A test suite with GitHub Actions would be very valuable. I see that qgisprocess uses the Geocompuation with R docker image as a low-effort entry point, but in GHA uses QGIS more directly: https://github.com/r-spatial/qgisprocess/blob/49ffca7362597582ae1d2e890c3cc46342d7874a/.github/workflows/R-CMD-check.yaml#L58-L102 and other variants. I guess your approach would resemble that.

I also like the idea of using the OSGEO GitHub organization, @florisvdh @veroandreo what do you think? We are an OSGeo community project https://www.osgeo.org/projects/r-spatial/, so there is also a proper link.

@veroandreo
Copy link
Collaborator

Hi Roger and Steven,

I also like the idea of using the OSGEO GitHub organization, @florisvdh @veroandreo what do you think? We are an OSGeo community project https://www.osgeo.org/projects/r-spatial/, so there is also a proper link.

Yes, I like this idea! @neteler, do you think we need to ask the OSGeo board or some committee first, or can we just proceed?

@neteler
Copy link
Member

neteler commented Dec 27, 2024

I think we can just proceed.

@stevenpawley
Copy link
Member

That's great, I think that it makes sense to have GRASS* related repos all in the same place. So, following on from Roger's original suggestion, hopefully we can look to proceed in early Jan?

@rsbivand
Copy link
Collaborator Author

@neteler @veroandreo To whom in the OSGeo github organization should I transfer ownership of the repo? @stevenpawley are you a member of the OSGeo organization on github? I understand that the recipient needs to respond to the transfer quickly, so we'd need to agree a time-zone-friendly day and time.

@stevenpawley
Copy link
Member

I'm a member of the OSGeo GitHub organization already, so I can be included as a maintainer.

@rsbivand
Copy link
Collaborator Author

Excellent! Then we can begin when you are ready, once I locate you, and you tell me you are ready to confirm the transfer. Maybe the weekend isn't ideal? Possibly from January 1 onwards, but earlier might work too.

@neteler
Copy link
Member

neteler commented Dec 27, 2024

If there is anything I can help with let me know (I have admin rights in the OSGeo-GH-org).

@rsbivand
Copy link
Collaborator Author

Thanks!

@stevenpawley
Copy link
Member

I think that in order to transfer a repository to another organization, Roger will need permission to create repositories in the OSGeo organization.

@neteler
Copy link
Member

neteler commented Dec 27, 2024

As said, I can do that for you. And then transfer the ownership.

@stevenpawley
Copy link
Member

Excellent! Then we can begin when you are ready, once I locate you, and you tell me you are ready to confirm the transfer. Maybe the weekend isn't ideal? Possibly from January 1 onwards, but earlier might work too.

I'm available really anytime at the moment. I can create a pull request with make some of the changes to the DESCRIPTION, and I think, as the new maintainer, I need to make the submission to CRAN (and you will receive an automated email to confirm the transfer). So, it looks like we need the repo to be transferred to OSGeo first so that we can update/finalize the URLs in the DESCRIPTION, rebuild the pkgdown site, etc., and then submit?

@rsbivand
Copy link
Collaborator Author

Yes, that is how I see it too. I'll try to begin tomorrow Monday CET, so that I can ask @neteler for help if my membership of the OSGeo organisation is needed.

@rsbivand
Copy link
Collaborator Author

@neteler Could you please add me to the OSGeo organization with the necessary rights?

To transfer repositories to an organization, you must have permission to create repositories in the receiving organization, and to transfer repositories out of the origin organization.

(https://docs.github.com/en/repositories/creating-and-managing-repositories/transferring-a-repository)

@neteler
Copy link
Member

neteler commented Dec 30, 2024

@neteler Could you please add me to the OSGeo organization with the necessary rights?

@rsbivand Yes: I have sent an membership invitation to you.

@neteler
Copy link
Member

neteler commented Dec 30, 2024

For the ease of team management, I have also created a new team "rgrass-write":

https://github.com/orgs/OSGeo/teams/rgrass-write

I think that you can modify it yourself as needed (@stevenpawley , @rsbivand , @veroandreo).
Note that I didn't see @florisvdh yet in the OSGeo organisation, let me know if that should be changed.

@rsbivand
Copy link
Collaborator Author

Transfer to OSGeo seems complete now.@neteler, please check and if OK reduce access rights for me. @stevenpawley please check your access - my git remote -v needs updating.

@neteler
Copy link
Member

neteler commented Dec 30, 2024

Transfer to OSGeo seems complete now.@neteler, please check

The https://github.com/OSGeo/rgrass repo looks good to me, congrats!

and if OK reduce access rights for me.

I have done so.

@veroandreo
Copy link
Collaborator

Thanks @rsbivand, @stevenpawley and @neteler !! 🚀

@stevenpawley
Copy link
Member

Thank you all, and especially @rsbivand and @neteler for your time to set this up, and for giving me the privilege of maintaining such a well-established R package. I'll check my access shortly.

I have a fork with a GitHub Actions test suite running on several Ubuntu versions and official GRASS Docker images that I'll look to integrate, hopefully today.

@rsbivand
Copy link
Collaborator Author

Maybe @neteler will need to raise access for @stevenpawley to be able to point the package documentation in GH pages to https://OSgeo.github.io/rgrass or a similar location. https://osgeo.github.io/rgrass/ is in fact online, but the GH About chunk still points to my account, and I don't see a cogwheel to access settings.

@neteler
Copy link
Member

neteler commented Dec 30, 2024

Here: https://github.com/OSGeo/rgrass/settings/pages I don't see any user-specific settings.

The last GH pages run was 1 month ago, according to https://github.com/OSGeo/rgrass/actions

An (even empty) git commit and push may be required to trigger a fresh rebuild of the GH pages.

@neteler
Copy link
Member

neteler commented Dec 30, 2024

An (even empty) git commit and push may be required to trigger a fresh rebuild of the GH pages.

I have prepared a small PR: #98

@neteler
Copy link
Member

neteler commented Dec 30, 2024

https://osgeo.github.io/rgrass/ is in fact online, but the GH About chunk still points to my account

In the code are many instances of the (now) old URL. I guess that these need to be updated to the new one. I can prepare a PR for that if desired.

@rsbivand
Copy link
Collaborator Author

@neteler Yes, please!

@neteler
Copy link
Member

neteler commented Dec 30, 2024

Done in #100.

@stevenpawley
Copy link
Member

Hi @neteler, when you get a chance, could we check permissions for the repo again - I don't appear to have push permissions (or permissions to merge pull requests, etc.).

@florisvdh
Copy link
Collaborator

All: congrats with these changes!! It makes sense to tie together GRASS-related repos at OSGeo GitHub, good idea indeed. Thanks and happy ending of 2024.

@neteler:

Note that I didn't see @florisvdh yet in the OSGeo organisation, let me know if that should be changed.

I'll be happy to keep contributing to rgrass at times! So yes you can add me to OSGeo organisation and rgrass-write. Thanks.

@neteler
Copy link
Member

neteler commented Jan 1, 2025

Hi @neteler, when you get a chance, could we check permissions for the repo again - I don't appear to have push permissions (or permissions to merge pull requests, etc.).

Hi @stevenpawley I have now added you as a project maintainer (dunno why this was missing, the GH roles management is still a bit obscure to me). Please let me know if the problem is now solved.

@neteler
Copy link
Member

neteler commented Jan 1, 2025

I'll be happy to keep contributing to rgrass at times! So yes you can add me to OSGeo organisation and rgrass-write. Thanks.

@florisvdh I have done so, you should find the invitation accordingly.

@stevenpawley
Copy link
Member

Hi @neteler, when you get a chance, could we check permissions for the repo again - I don't appear to have push permissions (or permissions to merge pull requests, etc.).

Hi @stevenpawley I have now added you as a project maintainer (dunno why this was missing, the GH roles management is still a bit obscure to me). Please let me know if the problem is now solved.

Thank you @neteler - seems to be working now.

@rsbivand
Copy link
Collaborator Author

rsbivand commented Jan 2, 2025

Have written to CRAN to inform of the maintainer transfer.

I am bumping the package version to 0.5-1, but maybe 1.0-1 is more appropriate?

@rsbivand
Copy link
Collaborator Author

rsbivand commented Jan 2, 2025

Reverse dependency checks OK, but one package had a pre-existing warning:
rgrass_051_250102.csv. Warning addressed in adamlilith/fasterRaster#117, so rgrass is ready to go when CRAN resumes submissions January 9.

@neteler
Copy link
Member

neteler commented Jan 3, 2025

FYI: I found the previous mistake, preventing @stevenpawley and others from writing:

https://github.com/OSGeo/rgrass/settings/access?query=filter%3Ateams

image

(originally it was set to "read"; now fixed)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants