Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

51.1.1 wording improvement #2520

Closed
elarlang opened this issue Jan 10, 2025 · 8 comments
Closed

51.1.1 wording improvement #2520

elarlang opened this issue Jan 10, 2025 · 8 comments
Assignees
Labels
1) Discussion ongoing Issue is opened and assigned but no clear proposal yet 5) awaiting PR A proposal hs been accepted and reviewed and we are now waiting for a PR V51 Group issues related to OAuth _5.0 - prep This needs to be addressed to prepare 5.0

Comments

@elarlang
Copy link
Collaborator

elarlang commented Jan 10, 2025

# Description L1 L2 L3
51.1.1 [ADDED] Verify that tokens are only sent to components that strictly need them. For example, avoid having access or refresh tokens accessible for the frontend when they are only needed by the backend.

Needs some language change to avoid the word avoid (as it is a command for the user, not requirement for an application).

edit: maybe we should list examples for access token, refresh token and ID-token?

@elarlang elarlang added _5.0 - prep This needs to be addressed to prepare 5.0 V51 Group issues related to OAuth labels Jan 10, 2025
@OWASP OWASP deleted a comment Jan 10, 2025
@TobiasAhnoff
Copy link
Contributor

Perhaps remove "avoid" and have something like this?

Verify that tokens are only sent to components that strictly need them. For example, access and refresh tokens should only be accessible for the backend (using a backend-for-frontend pattern for browser-based JavaScript applications).

or

Verify that tokens are only sent to components that strictly need them. For example, it is recommended to only have access and refresh tokens accessible for the backend (using a backend-for-frontend pattern for browser-based JavaScript applications).

@tghosth tghosth added the 1) Discussion ongoing Issue is opened and assigned but no clear proposal yet label Jan 16, 2025
@elarlang
Copy link
Collaborator Author

elarlang commented Jan 16, 2025

We need to avoid "should" and "recommended" in the requirements. The word "requirement" itself says it is "required" - MUST have as specified in https://datatracker.ietf.org/doc/html/rfc2119#section-1

@TobiasAhnoff
Copy link
Contributor

Then maybe this?

Verify that tokens are only sent to trusted components that strictly need them. For example, when using a backend-for-frontend pattern for browser-based JavaScript applications, access and refresh tokens shall only be accessible for the backend.

@elarlang
Copy link
Collaborator Author

Seems good, ping @randomstuff

@elarlang elarlang added the 4) proposal for review Issue contains clear proposal for add/change something label Jan 16, 2025
@randomstuff
Copy link
Contributor

OK for me.

@elarlang
Copy link
Collaborator Author

@TobiasAhnoff - please do the PR

@elarlang elarlang added 5) awaiting PR A proposal hs been accepted and reviewed and we are now waiting for a PR and removed 4) proposal for review Issue contains clear proposal for add/change something labels Jan 16, 2025
@elarlang
Copy link
Collaborator Author

Probably did not read it carefully enough before PR, but I don't like too much the word trusted here. I think the point for this requirement is not to define what the trusted component is and that is why it is not good to use the word at all.

@TobiasAhnoff
Copy link
Contributor

Ok, I agree, the word trusted need some context, I will update the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1) Discussion ongoing Issue is opened and assigned but no clear proposal yet 5) awaiting PR A proposal hs been accepted and reviewed and we are now waiting for a PR V51 Group issues related to OAuth _5.0 - prep This needs to be addressed to prepare 5.0
Projects
None yet
Development

No branches or pull requests

4 participants