Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐞 Docs/CLI incorrect - Creating Azure Function not possible #10795

Closed
andrewconnell opened this issue Jan 30, 2024 · 3 comments · Fixed by #10800
Closed

🐞 Docs/CLI incorrect - Creating Azure Function not possible #10795

andrewconnell opened this issue Jan 30, 2024 · 3 comments · Fixed by #10800
Assignees
Labels
investigating needs attention This issue needs the attention of a contributor. TA:Auth Team Area: Auth

Comments

@andrewconnell
Copy link
Contributor

Describe the bug
Unsure what's correct/incorrect - readme for project template Tab => React with Fluent UI says:

Add More Functions

  • From Visual Studio Code, open the command palette, select Teams: Add Resources and select Azure Function App.
  • From TeamsFx CLI: run command teamsfx resource add azure-function --function-name <your-function-name> in your project directory.

The second bullet is incorrect:

  • there's no resource command in teamsfx cli
  • there's no azure-function option when using teamsfx add

So, either the docs are incorrect in the README.md, or there's something missing in the TeamsFX CLI

To Reproduce
Steps to reproduce the behavior:

  1. Create new project using the template Tab > React with Fluent UI
  2. Follow instructions in 2nd bullet point on line 43 to add a new Azure Function
  3. See error

Expected behavior
No error... instructions are correct

Screenshots
n/a

VS Code Extension Information (please complete the following information):

  • OS: macos v14.12.1
  • Version v5.4.0

CLI Information (please complete the following information):

  • OS: macos v14.2.1
  • Version v2.1.1
@KennethBWSong
Copy link
Contributor

@andrewconnell Thank you for using our Toolkit! Would you please help to verify whether your project is created by latest TTK? Current README.md should be same as here. We used to support teamsfx resource add azure-function command previously, and now they are removed from latest CLI.

andrewconnell added a commit to andrewconnell/TeamsFx that referenced this issue Jan 31, 2024
- AzFunc project README references old & no-longer available TeamsFx
  CLI command ... this removes it
- see OfficeDev#10795 for discussion & confirmation
- fixes OfficeDev#10795
@andrewconnell
Copy link
Contributor Author

andrewconnell commented Jan 31, 2024

Yup, created using TTK v5.4 in the last 2w.

The template you linked to has the error as well (as does the TypeScript version). Will submit PR to fix...

There's no error in the README you referenced, it's in the Azure Function's README.

See: https://github.com/OfficeDev/TeamsFx/blob/dev/templates/js/sso-tab-with-obo-flow/api/README.md?plain=1#L43

@MuyangAmigo
Copy link
Collaborator

Yup, created using TTK v5.4 in the last 2w.

The template you linked to has the error as well (as does the TypeScript version). Will submit PR to fix...

There's no error in the README you referenced, it's in the Azure Function's README.

See: https://github.com/OfficeDev/TeamsFx/blob/dev/templates/js/sso-tab-with-obo-flow/api/README.md?plain=1#L43

Thanks @andrewconnell - we missed the README under api folder. Also thanks for fixing it!

KennethBWSong pushed a commit that referenced this issue Feb 2, 2024
- AzFunc project README references old & no-longer available TeamsFx
  CLI command ... this removes it
- see #10795 for discussion & confirmation
- fixes #10795
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
investigating needs attention This issue needs the attention of a contributor. TA:Auth Team Area: Auth
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants