Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Script action environment output regexp is too strict and do not support whitespaces #12102

Closed
alexanderbob opened this issue Jul 30, 2024 · 2 comments · Fixed by #12146
Closed
Assignees
Labels
feature-request The issue is a feature request investigating needs attention This issue needs the attention of a contributor. TA:E2E Team Area: E2E

Comments

@alexanderbob
Copy link

Describe the bug
Regular expression to parse teamsfx environment variables from script output is too strict and do not allow whitespaces or ' and "
Was introduced in #8811

To Reproduce
Steps to reproduce the behavior:
Run provisioning using the following yml file

version: 1.1.0

provision:
    - uses: script
      with:  
        run: "Write-Host ::set-teamsfx-env Test0=\"multi word variable\"
              Write-Host ::set-teamsfx-env Test1='multi word variable'
              Write-Host ::set-teamsfx-env Test2=multi+word+variable"
        shell: pwsh

Current behavior
Action script in lifecycle provision succeeded with output {"Test0":"multi","Test1":"multi","Test2":"multi+word+variable"}

Expected behavior
Test0 and Test1 variables in the output should both be "multi word variable"

Screenshots
If applicable, add screenshots to help explain your problem.
image
image

Copy link
Contributor

Thank you for contacting us! Any issue or feedback from you is quite important to us. We will do our best to fully respond to your issue as soon as possible. Sometimes additional investigations may be needed, we will usually get back to you within 2 days by adding comments to this issue. Please stay tuned.

@microsoft-github-policy-service microsoft-github-policy-service bot added the needs attention This issue needs the attention of a contributor. label Jul 30, 2024
@adashen adashen added investigating TA:E2E Team Area: E2E labels Jul 30, 2024
@jayzhang
Copy link
Member

jayzhang commented Aug 2, 2024

@alexanderbob Thanks for reporting. We will improve this to support quoted values.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request The issue is a feature request investigating needs attention This issue needs the attention of a contributor. TA:E2E Team Area: E2E
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants