Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OnAfterRenderAsync does not fire in configurable tabs. #12186

Closed
mmsharepoint opened this issue Aug 7, 2024 · 3 comments
Closed

OnAfterRenderAsync does not fire in configurable tabs. #12186

mmsharepoint opened this issue Aug 7, 2024 · 3 comments
Assignees
Labels
TA:Compute Team Area: Compute

Comments

@mmsharepoint
Copy link

mmsharepoint commented Aug 7, 2024

Describe the bug
protected override async Task OnAfterRenderAsync does not fire in configurable tabs.

To Reproduce
Steps to reproduce the behavior:

  1. Set up a default Tab project
  2. Only do default steps
  3. Press F5
  4. Add as personal app --> works
  5. Add to a team --> doesn't work

Expected behavior
protected override async Task OnAfterRenderAsync should fire in configurable tabs as well

VS Extension Information (please complete the following information):

  • OS: Windows
  • Version 17.10.63.65054
@microsoft-github-policy-service microsoft-github-policy-service bot added the needs attention This issue needs the attention of a contributor. label Aug 7, 2024
@kimizhu kimizhu added investigating TA:Compute Team Area: Compute and removed needs attention This issue needs the attention of a contributor. labels Aug 8, 2024
@mmsharepoint
Copy link
Author

It seems you missed to insert
@rendermode InteractiveServer
into the TabConfig.razor template

And this has another error:
Make sure that
$"{NavigationManager.BaseUri}/tab"
doesn`t end up with a "...//tab" in the url as it fails to display in the tab

@microsoft-github-policy-service microsoft-github-policy-service bot added the needs attention This issue needs the attention of a contributor. label Aug 9, 2024
@huimiu
Copy link
Member

huimiu commented Aug 12, 2024

Thanks @mmsharepoint, let me check our template and get back to you!

@huimiu huimiu removed the needs attention This issue needs the attention of a contributor. label Aug 12, 2024
@huimiu
Copy link
Member

huimiu commented Sep 5, 2024

Hey @mmsharepoint, sorry for late reply, could you please upgrade to VS 17.11 and give it a try? We've updated the templates in the new version of the Teams Toolkit, mainly migrating configurable tabs to static tabs. You can read more about it in this doc.

I tried it with VS 17.11.2 and was able to successfully add the tab to a team. If you run into any issues with the new version, please let us know. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TA:Compute Team Area: Compute
Projects
None yet
Development

No branches or pull requests

4 participants