You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Here I was hoping for an evening of helping to close up this ticket for you and you already seem to have it implemented. It looks like your work from 33274ee and onwards has resolved this ticket - let's close it up! ;)
In my opinion connectSource is a bit too "low level". It's intented to connect an already created AudioSource to rythm.
What i would love to give as API is more like connectExternalStream (I think the issue name have a mistake, i will update it) which is nothing more than the function given to .then() in the linked line.
WDYT ?
Okazari
changed the title
Expose a connectStreamSource() function
Expose a connectExternalStream() function
Jan 13, 2018
Rythm.js/src/Player.js
Line 60 in e1c7d75
Externalise this arrow function into a
connectStreamSource()
, expose it in the api and add it to the documentationThe text was updated successfully, but these errors were encountered: