Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose a connectExternalStream() function #29

Open
Okazari opened this issue Sep 5, 2017 · 3 comments
Open

Expose a connectExternalStream() function #29

Okazari opened this issue Sep 5, 2017 · 3 comments

Comments

@Okazari
Copy link
Owner

Okazari commented Sep 5, 2017

return this.getMicrophoneStream().then(stream => {

Externalise this arrow function into a connectStreamSource(), expose it in the api and add it to the documentation

@nesvand
Copy link
Contributor

nesvand commented Jan 13, 2018

Here I was hoping for an evening of helping to close up this ticket for you and you already seem to have it implemented. It looks like your work from 33274ee and onwards has resolved this ticket - let's close it up! ;)

@Okazari
Copy link
Owner Author

Okazari commented Jan 13, 2018

In my opinion connectSource is a bit too "low level". It's intented to connect an already created AudioSource to rythm.

What i would love to give as API is more like connectExternalStream (I think the issue name have a mistake, i will update it) which is nothing more than the function given to .then() in the linked line.

WDYT ?

@Okazari Okazari changed the title Expose a connectStreamSource() function Expose a connectExternalStream() function Jan 13, 2018
@nesvand
Copy link
Contributor

nesvand commented Jan 14, 2018

Sure let me think on it - I'll re-familiarise myself with the project (as it has been updated a bit since I last checked!) ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants