From d90f55d2f6a5d58c2a4e6452c8bfcda1fefb26b4 Mon Sep 17 00:00:00 2001 From: olf Date: Mon, 31 Aug 2020 15:42:49 +0200 Subject: [PATCH] Rectifying and enhancing incorrect comment WRT "Icon:" tag No icon *path*, just a pure basename makes sense in the SOURCE directory, because dirname of the icon path is always stripped by `rpmbuild`. --- rpm/sfos-upgrade.spec | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/rpm/sfos-upgrade.spec b/rpm/sfos-upgrade.spec index 6bbc73e..987b3c0 100644 --- a/rpm/sfos-upgrade.spec +++ b/rpm/sfos-upgrade.spec @@ -18,8 +18,8 @@ License: MIT URL: https://github.com/Olf0/%{name} Source: https://github.com/Olf0/%{name}/archive/%{version}/%{name}-%{version}.tar.gz # rpmbuild (as of v4.14.1) handles the Icon tag awkwardly and in contrast to the Source tag(s): -# It only accepts a file path to a GIF or XPM file (successfully tested GIF89a and XPMv3) rooted -# in the SOURCE directory (but not in the tarball)! +# It only accepts a GIF or XPM file (successfully tested GIF89a and XPMv3, but an XPM icon results +# in a bad visual quality and large file size) in the SOURCE directory (but not in the tarball)! # Hence only to be used, when the file is put there: # Icon: up.256x256.gif BuildArch: noarch