Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem with dependency on androidx.work:work-runtime-ktx:2.7.1 #783

Closed
1 task done
andy-weinstein opened this issue Nov 2, 2023 · 3 comments
Closed
1 task done

Comments

@andy-weinstein
Copy link

andy-weinstein commented Nov 2, 2023

How can we help?

The onesignal_flutter package has an indirect dependency on androidx.work:work-runtime-ktx:2.7.1. This Kotlin extension (ktx) library further depends on androidx.work:work-runtime:2.7.1.

In my project, another package depends on androidx.work:work-runtime:2.8.1. While Gradle attempts to resolve this by using version 2.8.1 for work-runtime, it does not do the same for work-runtime-ktx. As a result, we have work-runtime-ktx at 2.7.1 expecting its counterpart to be 2.7.1, but it's actually 2.8.1 due to the other package. This mismatch causes a build conflict.

It would be helpful if onesignal_flutter could update its dependency to a newer version of androidx.work, or make it more flexible, to prevent such conflicts.

As it is, I included the following in my app/build.gradle:
dependencies {
# leaving out other irrelevant directives here

implementation('androidx.work:work-runtime-ktx:2.8.1') {
 force = true
}

}
It seems to be working fine - only did an initial test push, but it worked.

Code of Conduct

  • I agree to follow this project's Code of Conduct
@emawby
Copy link
Contributor

emawby commented Nov 6, 2023

Hello thank you for reaching out. I believe this has already been fixed in our Android SDK here, and will be available in the next flutter version release. Thank you for your patience while we get the release out!

@nan-li
Copy link
Contributor

nan-li commented Jan 17, 2024

Noting: Added additional fix for this in the latest OneSignal Android SDK release v5.1.1.

Will be fixed in the next onesignal Flutter SDK release.

@nan-li
Copy link
Contributor

nan-li commented Jan 30, 2024

Hi @andy-weinstein, thanks again for reporting this issue and your patience.

We have released the fix in Release 5.1.0.

Please update and reach out if you are still seeing issues. Thanks!

@nan-li nan-li closed this as completed Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants