Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

research: is it possible to 'calculate' the formula when processing, instead of afterwards? #148

Open
dieuska opened this issue Dec 16, 2024 · 1 comment
Assignees
Labels
Milestone

Comments

@dieuska
Copy link
Collaborator

dieuska commented Dec 16, 2024

At the moment, the formula calculation is a function that can be executed afterwards a resulting geometry is processed.

These calculations also happend when the 'processing' was done. So maybe it is a speed enhancement to keep all information while processing to collect the information for the brdr_formula?

@dieuska dieuska added this to the future milestone Dec 16, 2024
@dieuska dieuska self-assigned this Dec 16, 2024
@maarten-vermeyen
Copy link
Contributor

I feel these should be kept separate. The act of realigning and the act of comparing the resulting geometry with the source geometries from which it is derived are conceptually different. We could apply the same comparison on geometries that are not realigned, and the API should ideally reflect this. Also, we could now "easily" represent the provenance of the resulting geometry (i.e. the realignment) in PROV-O standard and the comparison (which is a type of observation) in SSNO. Integrating both in the same functions and code base will couple the implementation of both aspects, making it harder to afterwards change them or use them with different alignement procedures/observations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants