Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: Compatibility information #5

Open
lisbetoo opened this issue Jul 13, 2024 · 2 comments
Open

[Enhancement]: Compatibility information #5

lisbetoo opened this issue Jul 13, 2024 · 2 comments

Comments

@lisbetoo
Copy link

I find it annoying to install incompatible OXPs without knowing, and irksome to lose dependency information. I am using the Oolite Starter version 0.1.31, which was the last version not listed as pre-release when I downloaded it.

A specific example of the first is the Vector OXP. I upgraded to Oolite 1.90, and installed all the Mission OXPs I found on the list. I then had occasion to go to the Wiki, and found that the Vector OXP isn't expected to function with version 1.90. It would be nice to list which version(s) of Oolite an OXP is compatible with in the description/lower pane, and/or to filter out OXPs incompatible with the selected Oolite version.

On the second I mentioned, OXPs that depend on others only mention their dependency when the necessary other OXP is not installed. It would be helpful to keep this information instead of removing it, and possibly to assign these dependent OXPs a marker even when the required other OXPs are installed. A specific example is the Iron Raven and Armoured Transport Type 1 OXPs.

@oocube
Copy link
Collaborator

oocube commented Nov 11, 2024

Sorry for coming back so late.

The Vector OXP is published at https://wiki.alioth.net/img_auth.php/d/dc/Vector_1.7.2.oxz
Inside the manifest.plist it lists

"required_oolite_version" = "1.79";

and

"requires_oxps" = (
{
"identifier" = "oolite.oxp.Svengali.CCL";
"version" = "1.6";
},
{
"identifier" = "oolite.oxp.Svengali.Snoopers";
"version" = "2.3.3";
}
);

Indeed this is not indicated by OoliteStarter. I will investigate.

@oocube
Copy link
Collaborator

oocube commented Nov 11, 2024

In my initial setup, both CCL and Snoopers were already installed. Hence Vector did not need any further markup.
When removing any of CCL or Snoopers, Vector was reliably marked as 'red' which means it is problematic due to conflicts or dependencies. Also the missing library was shown. In this respect OoliteStarter works as designed.

Regarding the version number, the Vector OXP carries the required_oolite_version, which - as per documentation - is the minimum required version. To markup it is only compatible to that version the manifest.plist should also contain the maximum_oolite_version as is documented here. So again, OoliteStarter behaves as is to be expected, and a change is required in the OXPs manifest.

But to not loose such dependency information just because the dependencies are fulfilled, I changed the code to also show them in case they are present.

oocube pushed a commit that referenced this issue Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants