Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-integrate better into mlx_lm #33

Open
uogbuji opened this issue Jan 11, 2025 · 1 comment · May be fixed by #36
Open

Re-integrate better into mlx_lm #33

uogbuji opened this issue Jan 11, 2025 · 1 comment · May be fixed by #36
Assignees

Comments

@uogbuji
Copy link
Contributor

uogbuji commented Jan 11, 2025

Our upstream llm_structured_output, which has since been vendored in, was developed prior to some core mlx/mlx_lm features, and lots of interface changes. It's a bit stale, and we're pretty clearly tripping over wires everywhere.

Time to rewrite the code, with primary locus of https://github.com/OoriData/Toolio/blob/main/pylib/schema_helper.py

@uogbuji
Copy link
Contributor Author

uogbuji commented Jan 11, 2025

Note: we'll want to keep an eye on mlx_lm's new speculative decoding, and decide whether to wire in that option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants