-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Review comments to tool update in pull request #1 #7
Comments
@bzeuner Thanks very much for the detailed review! NO.1~6 are easy to fix. |
Hallo @XingZhao-CATR Regarding 7.: According to my understanding (which may be wrong) I did expect in the class-4-identifier path only the identifier and vice versa in the class-4-other-id path only the other-Id. Regarding 8.: The path for the blue naming tree is different from the path for the red naming tree; i.e., Regarding 10.: |
Hallo @XingZhao-CATR,
Thank you for the updated tool. Here my review comments:
The text was updated successfully, but these errors were encountered: