Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config option to disable The Maestro #17

Closed
OpenBagTwo opened this issue Dec 4, 2022 · 4 comments
Closed

Add config option to disable The Maestro #17

OpenBagTwo opened this issue Dec 4, 2022 · 4 comments
Labels
enhancement New feature or request

Comments

@OpenBagTwo
Copy link
Owner

😢

In the spirit of keeping this mod "Vanilla Plus," there should be an option to disable the conductor profession for players who prefer to obtain music discs by other means (#16).

This does not need to be part of the initial release but should be done in tandem with #13 (note that without #13, it's pretty trivial to keep Conductors from generating in your world)

Implementation Suggestion

Should be pretty trivial: just put this line behind an if condition:

https://github.com/OpenBagTwo/FoxNap/blob/1.19.2/src/main/java/net/openbagtwo/foxnap/FoxNap.java#L28

@OpenBagTwo OpenBagTwo added the enhancement New feature or request label Dec 4, 2022
@OpenBagTwo OpenBagTwo added this to the v0.1.2 Release milestone Jun 7, 2023
@uczpre
Copy link

uczpre commented Mar 12, 2024

Dont need man , the Disco mod exist , it has easier installation too since everything is inside 1 .jar

@OpenBagTwo
Copy link
Owner Author

I mean, is there any reason in general not just to use the Disco mod?

@uczpre
Copy link

uczpre commented Apr 23, 2024

well , for once it doesnt provide a way for people to acquire the music disc in survival.
the generator is horrible too , it requires us to upload and set a tag manually for each audio file ! upload ? oh yeah , its a website.
while your generator may be missing a few things here and there , its still miles ahead.
in general , the disco mod is not the most featured and convenient mod when compared to your creation ;D
nice mod man !

OpenBagTwo added a commit that referenced this issue Apr 26, 2024
Completing the implementation of #17
@OpenBagTwo
Copy link
Owner Author

This change is live in v0.1.2 for Minecraft 1.19.4-1.20.5. Keeping it open until I backport it to the ole 1.19 build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants