Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build_mod workflow jars show version as 0.0.0-0 #27

Closed
OpenBagTwo opened this issue Dec 5, 2022 · 4 comments
Closed

build_mod workflow jars show version as 0.0.0-0 #27

OpenBagTwo opened this issue Dec 5, 2022 · 4 comments
Labels
bug Something isn't working dev ops CI/CD
Milestone

Comments

@OpenBagTwo
Copy link
Owner

Unclear if these are just filenames or the actual versions that will show up in-game. I'm especially concerned that actual release builds still won't pick up the version.

This seems like the Java equivalent of versioneer's 0+unknown issue, but I don't have this problem building locally, and the process should be identical on the workers.

It's not strictly necessary that this be resolved before the release--I don't even have a release workflow (#26)--as I can always use a local build as the release jar, but if jgitver isn't working for me, I should see what other options are out there (I know I have mods I've used where the version shows as "1.19+build.6")

@OpenBagTwo OpenBagTwo added bug Something isn't working dev ops CI/CD labels Dec 5, 2022
@OpenBagTwo
Copy link
Owner Author

This is also an issue with versioneer: builds of FoxNapRPG showing as, for example,

foxnap-rpg-0+untagged.1.gcf466df

This is a major problem because while I do have access to Mac and Windows (through a VM), doing manual builds would be a pain in the toucans.

@OpenBagTwo OpenBagTwo added this to the v0.1 Release milestone Dec 5, 2022
OpenBagTwo added a commit that referenced this issue Dec 5, 2022
Hoping this is the solution for #27
@OpenBagTwo
Copy link
Owner Author

Okay, I suddenly remember this sort of thing happening in Jenkins once the number of commits since the last release got super high. I'm hopeful that b21162a might let me work around this.

OpenBagTwo added a commit that referenced this issue Dec 5, 2022
Hoping this is the solution for #27
@OpenBagTwo
Copy link
Owner Author

Resolved by #28

@OpenBagTwo
Copy link
Owner Author

Just noticed the build is missing the "1.19.2" suffix... Not gonna worry about it for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dev ops CI/CD
Projects
None yet
Development

No branches or pull requests

1 participant