Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Split the collect command into two commands #13

Open
davidallendj opened this issue Mar 13, 2024 · 0 comments
Open

[FEATURE] Split the collect command into two commands #13

davidallendj opened this issue Mar 13, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@davidallendj
Copy link
Collaborator

davidallendj commented Mar 13, 2024

Description of Issue

The magellan tool should be able to only have it's output printed to stdout and optionally make a HTTP request. This would allow users to collect information from nodes to use in other scripts or tools without the magellan tool trying to make additional requests afterwards. This also makes magellan more useful as an independent tool that is decoupled from other microservices.

Possible Solution

The motivation of this feature is to break up the collect command and make its functionality more flexible. This would require making another command for taking the inventory data produced from collect and making a request to a specified host. Therefore, to achieve the same functionality of the current collect, the two commands would have to run something like this:

magellan collect --username $USERNAME --password $PASSWORD
magellan upload --host https://example.openchami.cluster:27779

Other Considerations

In combination with #13, the collect output could be used as input for the upload command (or whatever it will be called). Therefore, both commands mentioned above would be able to be used together with pipes.

magellan collect --username $USERNAME --password $PASSWORD | magellan upload --host https://example.openchami.cluster:27779

If the scan and collect command follow the same convention, there the entire process can be combined like the following:

magellan scan --subnet 172.16.0.0 --subnet-mask 255.255.255.100 | magellan collect --username $USERNAME --password $PASSWORD | magellan upload --host https://example.openchami.cluster:27779

Therefore, the process can also be broken down into scan/collect and collect/upload combinations.

@davidallendj davidallendj added the enhancement New feature or request label Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant