Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong place of calling rawurldecode #2

Open
landgrafhomyak opened this issue Sep 14, 2024 · 0 comments
Open

Wrong place of calling rawurldecode #2

landgrafhomyak opened this issue Sep 14, 2024 · 0 comments

Comments

@landgrafhomyak
Copy link

Currently rawurldecode called before splitting line by & (here):

    private static function convertInitData(string $initData): array
    {
        $initDataArray = explode('&', rawurldecode($initData));
        $needle        = 'hash=';
        $hash          = '';

But if user will add & to his first_name or last_name, this will cause additional wrong "entry" in $initDataArray and will fail validation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant