Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No Results From Search #4

Closed
mko237 opened this issue Jun 4, 2023 · 1 comment
Closed

No Results From Search #4

mko237 opened this issue Jun 4, 2023 · 1 comment

Comments

@mko237
Copy link

mko237 commented Jun 4, 2023

Hi,

I found this package from a comment on this same issue, reported over on the original python-raindropio package.

I switched to this package hoping it would help but seems that it has the same problem.

If you see my comment on the original issue, you should be able to apply the same fix to the line here

Thanks, hope this helps.
PBorocz added a commit that referenced this issue Jun 6, 2023
@PBorocz
Simplify search API args (API change!); Addresses #4.
24035b9 
JSON anymore, instead...a direct search string (which itself can incorporate
tag(s), date semantics etc.). Thus I've changed the search API method
to simply take a search string (instead of word, tag or important) *AND* to
directly send said search string (instead of JSONifying it).
@PBorocz
Copy link
Owner

PBorocz commented Jun 6, 2023

Thanks @mko237!
Indeed it would be here as the core API code was essentially cloned from Atsuo's package.

Although I can't confirm through WaybackMachine (but I'm positive search worked correctly before), it seems like the raindropio API doesn't take a JSON-encoded search parameter anymore, instead just the same string we'd use through their UI ("searchMe", "#MyTag" etc.).

Thus, I've simplified the API call to Raindrop.search and confirmed that wildcard searches work (either against a single or all collections).

Thanks for the feedback!

@PBorocz PBorocz closed this as completed Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@PBorocz @mko237