From c03e7b0ff79f68db53491b04d207179514dbbc70 Mon Sep 17 00:00:00 2001
From: Nicholas Wilson <niwilson@microsoft.com>
Date: Sat, 7 Dec 2024 19:32:06 +0000
Subject: [PATCH] Suppress some minor analysis warnings (#593)

One of these appears in Coverity's dashboard; the rest are from clang-scan.

See #576
---
 src/pcre2_compile.c       | 4 ++--
 src/pcre2_compile_class.c | 3 +++
 src/pcre2_dfa_match.c     | 2 +-
 src/pcre2grep.c           | 7 +++++--
 src/pcre2posix.c          | 5 ++++-
 5 files changed, 15 insertions(+), 6 deletions(-)

diff --git a/src/pcre2_compile.c b/src/pcre2_compile.c
index c3fd6cc11..fe6e40dfb 100644
--- a/src/pcre2_compile.c
+++ b/src/pcre2_compile.c
@@ -7113,7 +7113,6 @@ for (;; pptr++)
     single-char opcodes. */
 
     reqvary = (repeat_min == repeat_max)? 0 : REQ_VARY;
-    op_type = 0;
 
     /* Adjust first and required code units for a zero repeat. */
 
@@ -7676,7 +7675,8 @@ for (;; pptr++)
           }
         else
           {
-          /* Come here from just above with a character in mcbuffer/mclength. */
+          /* Come here from just above with a character in mcbuffer/mclength.
+          You must also set op_type before the jump. */
           OUTPUT_SINGLE_REPEAT:
           prop_type = prop_value = -1;
           }
diff --git a/src/pcre2_compile_class.c b/src/pcre2_compile_class.c
index 3428c6724..7037ed0a3 100644
--- a/src/pcre2_compile_class.c
+++ b/src/pcre2_compile_class.c
@@ -256,6 +256,7 @@ while (c <= end)
     buffer[0] = new_start;
     buffer[1] = new_end;
     buffer += 2;
+    (void)buffer;
     }
   return result;
 }
@@ -341,6 +342,7 @@ while (*p != NOTACHAR)
     buffer[0] = start;
     buffer[1] = get_highest_char(options);
     buffer += 2;
+    (void)buffer;
     }
 
   return result;
@@ -756,6 +758,7 @@ for (c = 0; c < 256; c++)
   {
   prop = GET_UCD(c);
   set_bit = FALSE;
+  (void)set_bit;
 
   switch (ptype)
     {
diff --git a/src/pcre2_dfa_match.c b/src/pcre2_dfa_match.c
index 503502b76..d300394c9 100644
--- a/src/pcre2_dfa_match.c
+++ b/src/pcre2_dfa_match.c
@@ -3070,7 +3070,7 @@ for (;;)
         if (codevalue == OP_BRAPOSZERO)
           {
           allow_zero = TRUE;
-          codevalue = *(++code);  /* Codevalue will be one of above BRAs */
+          ++code;  /* The following opcode will be one of the above BRAs */
           }
         else allow_zero = FALSE;
 
diff --git a/src/pcre2grep.c b/src/pcre2grep.c
index 7ad6d4dd8..d56bfb411 100644
--- a/src/pcre2grep.c
+++ b/src/pcre2grep.c
@@ -3067,7 +3067,6 @@ while (ptr < endptr)
         if (group_separator != NULL)
           fprintf(stdout, "%s%s", group_separator, STDOUT_NL);
         hyphenpending = FALSE;
-        hyphenprinted = TRUE;
         }
 
       /* Now print the matching line(s); ensure we set hyphenpending at the end
@@ -3882,8 +3881,12 @@ else
   filename = name;
   }
 
-while ((patlen = sizeof(buffer)) && read_pattern(buffer, &patlen, f))
+while (TRUE)
   {
+  patlen = sizeof(buffer);
+  if (!read_pattern(buffer, &patlen, f))
+    break;
+
   if (!posix_pattern_file)
    {
    while (patlen > 0 && isspace((unsigned char)(buffer[patlen-1]))) patlen--;
diff --git a/src/pcre2posix.c b/src/pcre2posix.c
index 933004c51..f9dcbceba 100644
--- a/src/pcre2posix.c
+++ b/src/pcre2posix.c
@@ -94,6 +94,7 @@ changed. This #define is a copy of the one in pcre2_internal.h. */
 
 #include "pcre2.h"
 #include "pcre2posix.h"
+#include "pcre2_util.h"
 
 /* Table to translate PCRE2 compile time error codes into POSIX error codes.
 Only a few PCRE2 errors with a value greater than 23 turn into special POSIX
@@ -194,7 +195,7 @@ if (preg != NULL && (int)preg->re_erroffset != -1)
   /* no need to deal with UB in snprintf */
   if (errbuf_size > INT_MAX) errbuf_size = INT_MAX;
 
-  /* there are 11 charactes between message and offset,
+  /* there are 11 characters between message and offset;
      update message_len() if changed */
   ret = snprintf(errbuf, errbuf_size, "%s at offset %d", message,
                  (int)preg->re_erroffset);
@@ -210,6 +211,8 @@ else
   ret = (int)len;
   }
 
+PCRE2_ASSERT(len > 0 || preg != NULL);
+
 do {
   if (ret < 0)
     {