You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Thank you for submitting your paper to The Journal Of Open Software (JOSS) (Issue: openjournals/joss-reviews#7563). I have some minor comments that might enhance the paper.
The statement of need should be enhanced by adding the limitation and comparing it with other available packages that do the same functionality, such as ppx in Python and prideR in R.
The benchmarking of download speed should be modified with the packages mentioned above to show the differences between them and your package.
In GitHub examples, It would be great if you could add more examples about different filters that could be applied by the user.
The text was updated successfully, but these errors were encountered:
Hi @MohmedSoudy thanks for reviewing the library, here are some comments:
prideR (https://github.com/PRIDE-R/prideR) was a library originally developed to interact between R and PRIDE API 2014. The library is not maintained anymore, mainly because the majority of the users use Python to download and interact with the API. prideR hasn't been maintained anymore since 2015 (more than 10 years ago), so it would be difficult to benchmark.
ppx aims to retrieve data from multiple ProteomeXchange databases using https, and it is maintained by a team outside PRIDE Archive. pridepy is maintained by the PRIDE team, and it is only dedicated to PRIDE resources, it supports multiple PRIDE protocols Aspera, HTTP (as ppx) and Globus HTTPs, it also supports downloads from private datasets. I do think is good to acknowledge in the manuscript the existence of ppx. We will modify the manuscript.
We will add more examples about how to use the library.
Thank you for submitting your paper to The Journal Of Open Software (JOSS) (Issue: openjournals/joss-reviews#7563). I have some minor comments that might enhance the paper.
The text was updated successfully, but these errors were encountered: