- Never push directly to master (this should be enforced by github already).
- Create a new branch, e.g.
git checkout -b add-feature-x
, commit changes and push the branch. Then create the PR. - Never merge your own PR. Ask somebody to review it.
- Only the reviewer should merge the PR.
- It's OK to go back and forth, and changes things in your branch, until the PR is acceptable.
- It's OK to merge the PR using the
Squash and merge button
. - Code, comments, commit messages and PR discussions should be in English. In order to make this project more inviting to the community.
- Always delete the branch after the PR is merged.