Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improper return value from parse_hex_line in case of bad checksums #80

Open
farmisen opened this issue Jun 29, 2022 · 0 comments
Open

Comments

@farmisen
Copy link

farmisen commented Jun 29, 2022

looks like parse_hex_line should return 0 instead of 1 when the checksum is invalid

https://github.com/PaulStoffregen/teensy_loader_cli/blob/master/teensy_loader_cli.c#L927
https://github.com/PaulStoffregen/teensy_loader_cli/blob/master/teensy_loader_cli.c#L936

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant